2007-10-14 15:39:40

by Fabien Chevalier

[permalink] [raw]
Subject: [Bluez-devel] [PATCH] Small headset.c fixes

_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel


Attachments:
headset.patch (1.26 kB)
(No filename) (314.00 B)
(No filename) (164.00 B)
Download all attachments

2007-10-15 01:48:25

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: Re: [Bluez-devel] [PATCH] Small headset.c fixes

Hi Fabien,

On 10/14/07, Fabien Chevalier <[email protected]> wrote:
> Hi All,
>
> Please find attached a rather small patch, that fixes some small issues
> i found while reading headset.c code:
> * make String representation of state consistent with the state name
> * send Stop() signal only if we transition from playing state, not
> playin_in_progress
> * remove unused io_id field.

Thought we should not emit Stopped signal please maintain the code
for sco cleanup (close_sco), sco connection may fail or disconnected
before we got a chance to change the state to playing.

Besides that it seems good to me.

-- =

Luiz Augusto von Dentz
Engenheiro de Computa=E7=E3o

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel