Howdy folks. The attached patch makes the applet, properties dialog, and
wizard singletons. Currently, you can open several instances of these at a
time. This is particularly annoying since you can launch the properties
dialog from the applet. I also added a simple DBUS method (Present) to the
properties dialog and wizard that can be called by another instance to bring
the current instance to the foreground.
Chris
Hi Bastien,
> > actually I do think that the current behavior should be default. I
> > really want that behavior. There are corner cases that need to be
> > thought of and making it a singleton only hides these issues.
> >
> > However having a special switch that makes it a singleton would be a
> > good enhancement and I agree with you that any application started by
> > the applet should only exists once. The applet can use that specific
> > switch easily and we don't break current behavior.
>
> As long as the switch exists, I don't mind. I'd probably make it the
> default for Fedora, in the .desktop files, and it wouldn't break normal
> development use.
sorry I wasn't clear on this. Yes, in the .desktop it should be also
included. Only when calling it from the terminal it should keep the
current behavior, because that is what I expect when I type a command.
Regards
Marcel
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
On Wed, 2007-10-31 at 17:14 +0100, Marcel Holtmann wrote:
<snip>
> actually I do think that the current behavior should be default. I
> really want that behavior. There are corner cases that need to be
> thought of and making it a singleton only hides these issues.
>
> However having a special switch that makes it a singleton would be a
> good enhancement and I agree with you that any application started by
> the applet should only exists once. The applet can use that specific
> switch easily and we don't break current behavior.
As long as the switch exists, I don't mind. I'd probably make it the
default for Fedora, in the .desktop files, and it wouldn't break normal
development use.
Chris, can you update the patches for that?
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
Hi Fabien,
> >> actually the wizard and the properties applications are meant
> >> to be
> >> _not_ singletons. They are designed in a way that multiple
> >> instances can
> >> exist and work together.
> >>
> >> For the applet, only one instance is useful. However for
> >> testing and
> >> development purposes it is nice to start two of them.
> >>
> >> The applet already has the ability to launch the properties dialog and
> >> I think it should also have an entry to launch the wizard. This
> >> makes it very easy to get to a state where you have multiple copies
> >> open at once. I think it's confusing to users and it doesn't buy you
> >> anything. Just in case it's not clear, the patch allows for one
> >> instance per desktop session.
> >
> > Both of you are right. Developers should be able to launch another
> > applet or prefs for testing, but users should only ever see one applet
> > and prefs dialogue.
> >
> > Maybe a command-line flag or envvar to disable the singleton behaviour
> > in Chris' patch would be acceptable for Marcel?
>
> Bastien, i agree with you. :-)
> From the user experience perspective, having more than one instance of
> those windows is just plain wrong( in fact this was a remark one working
> collegue of mine just had when he discovered the bluez GUI for the first
> time :-) )
> If Marcel wants to keep the old behaviour for testing purpose, i'm not
> against it, but i really think the singleton behavior should be the default.
actually I do think that the current behavior should be default. I
really want that behavior. There are corner cases that need to be
thought of and making it a singleton only hides these issues.
However having a special switch that makes it a singleton would be a
good enhancement and I agree with you that any application started by
the applet should only exists once. The applet can use that specific
switch easily and we don't break current behavior.
Regards
Marcel
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
Here's an updated patch that will ignore the singleton behavior if the
BLUEZ_IGNORE_SINGLETON environment variable is set. Marcel, is this
acceptable?
Chris
On 10/17/07, Bastien Nocera <[email protected]> wrote:
>
>
> Both of you are right. Developers should be able to launch another
> applet or prefs for testing, but users should only ever see one applet
> and prefs dialogue.
>
> Maybe a command-line flag or envvar to disable the singleton behaviour
> in Chris' patch would be acceptable for Marcel?
>
> Cheers
>
Bastien Nocera wrote:
> On Wed, 2007-10-17 at 10:48 -0400, Chris Rivera wrote:
>> On 10/17/07, Marcel Holtmann <[email protected]> wrote:
>>
>> actually the wizard and the properties applications are meant
>> to be
>> _not_ singletons. They are designed in a way that multiple
>> instances can
>> exist and work together.
>>
>> For the applet, only one instance is useful. However for
>> testing and
>> development purposes it is nice to start two of them.
>>
>> The applet already has the ability to launch the properties dialog and
>> I think it should also have an entry to launch the wizard. This
>> makes it very easy to get to a state where you have multiple copies
>> open at once. I think it's confusing to users and it doesn't buy you
>> anything. Just in case it's not clear, the patch allows for one
>> instance per desktop session.
>
> Both of you are right. Developers should be able to launch another
> applet or prefs for testing, but users should only ever see one applet
> and prefs dialogue.
>
> Maybe a command-line flag or envvar to disable the singleton behaviour
> in Chris' patch would be acceptable for Marcel?
>
> Cheers
>
Bastien, i agree with you. :-)
From the user experience perspective, having more than one instance of
those windows is just plain wrong( in fact this was a remark one working
collegue of mine just had when he discovered the bluez GUI for the first
time :-) )
If Marcel wants to keep the old behaviour for testing purpose, i'm not
against it, but i really think the singleton behavior should be the default.
Cheers,
Fabien
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
On Wed, 2007-10-17 at 10:48 -0400, Chris Rivera wrote:
> On 10/17/07, Marcel Holtmann <[email protected]> wrote:
>
> actually the wizard and the properties applications are meant
> to be
> _not_ singletons. They are designed in a way that multiple
> instances can
> exist and work together.
>
> For the applet, only one instance is useful. However for
> testing and
> development purposes it is nice to start two of them.
>
> The applet already has the ability to launch the properties dialog and
> I think it should also have an entry to launch the wizard. This
> makes it very easy to get to a state where you have multiple copies
> open at once. I think it's confusing to users and it doesn't buy you
> anything. Just in case it's not clear, the patch allows for one
> instance per desktop session.
Both of you are right. Developers should be able to launch another
applet or prefs for testing, but users should only ever see one applet
and prefs dialogue.
Maybe a command-line flag or envvar to disable the singleton behaviour
in Chris' patch would be acceptable for Marcel?
Cheers
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
On 10/17/07, Marcel Holtmann <[email protected]> wrote:
>
> actually the wizard and the properties applications are meant to be
> _not_ singletons. They are designed in a way that multiple instances can
> exist and work together.
>
> For the applet, only one instance is useful. However for testing and
> development purposes it is nice to start two of them.
>
The applet already has the ability to launch the properties dialog and I
think it should also have an entry to launch the wizard. This makes it
very easy to get to a state where you have multiple copies open at once. I
think it's confusing to users and it doesn't buy you anything. Just in case
it's not clear, the patch allows for one instance per desktop session.
Chris
Hi Chris,
> Howdy folks. The attached patch makes the applet, properties dialog,
> and wizard singletons. Currently, you can open several instances of
> these at a time. This is particularly annoying since you can launch
> the properties dialog from the applet. I also added a simple DBUS
> method (Present) to the properties dialog and wizard that can be
> called by another instance to bring the current instance to the
> foreground.
actually the wizard and the properties applications are meant to be
_not_ singletons. They are designed in a way that multiple instances can
exist and work together.
For the applet, only one instance is useful. However for testing and
development purposes it is nice to start two of them.
Regards
Marcel
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
Any word on this?
Chris
On Nov 13, 2007 12:06 PM, Chris Rivera <[email protected]> wrote:
> On Nov 13, 2007 11:30 AM, Bastien Nocera <[email protected]> wrote:
> > Could you modify the .desktop file that starts the applet as well?
> >
>
> Updated patch to include desktop file modification.
>
> Chris
>
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
On Tue, 2007-11-13 at 11:24 -0500, Chris Rivera wrote:
> On Oct 31, 2007 11:24 AM, Bastien Nocera <[email protected]> wrote:
> >
> > On Wed, 2007-10-31 at 17:14 +0100, Marcel Holtmann wrote:
> > <snip>
> > > actually I do think that the current behavior should be default. I
> > > really want that behavior. There are corner cases that need to be
> > > thought of and making it a singleton only hides these issues.
> > >
> > > However having a special switch that makes it a singleton would be a
> > > good enhancement and I agree with you that any application started by
> > > the applet should only exists once. The applet can use that specific
> > > switch easily and we don't break current behavior.
> >
> > As long as the switch exists, I don't mind. I'd probably make it the
> > default for Fedora, in the .desktop files, and it wouldn't break normal
> > development use.
> >
> > Chris, can you update the patches for that?
>
> Sorry for the delayed response. Attached is an updated patch that
> adds a flag to enable the singleton behavior.
Could you modify the .desktop file that starts the applet as well?
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel