2008-03-06 18:48:34

by Stefan Seyfried

[permalink] [raw]
Subject: [Bluez-devel] [patch] make apitest more useful

This trivial 2-character patch makes apitest much more useful by allowing
stuff like "apitest -l DiscoverDevices" to work like i'd expect it to:

--- /usr/bin/apitest 2008-03-02 19:22:20.000000000 +0100
+++ /home/seife/bin/apitest.seife 2008-03-06 19:44:52.000000000 +0100
@@ -415,7 +415,7 @@ class Tester:
self.dbus_dev_sig_setup()
print 'Listening for events...'

- elif self.cmd in mgr_cmds:
+ if self.cmd in mgr_cmds:
try:
self.dbus_mgr_setup()
except dbus.DBusException, e:


Now we can alias "hcitool scan" to "apitest -l DiscoverDevices" ;-)
-- =

Stefan Seyfried
R&D Team Mobile Devices | "Any ideas, John?"
SUSE LINUX Products GmbH, N=FCrnberg | "Well, surrounding them's out."

This footer brought to you by insane German lawmakers:
SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG N=FCrnberg)

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel


2008-03-07 15:06:55

by Stefan Seyfried

[permalink] [raw]
Subject: Re: [Bluez-devel] [patch] make apitest more useful

Hi Marcel,

On Fri, Mar 07, 2008 at 03:16:09PM +0100, Marcel Holtmann wrote:

> the apitest is really only a test program,

I know :-)
It is still useful to hand out to people for debugging their setup.
As it is much more low level than bluez-gnome and kdebluetooth, it
is easier to tell a bug reporter *exactly* what to do with apitest
than with the grapical tools. That's why i bothered fixing that issue.

> but I applied the patch neverless.

Thanks. It now actually allows to test "DiscoverDevices" which is much
more useful, even as testing tool only ;-)
-- =

Stefan Seyfried
R&D Team Mobile Devices | "Any ideas, John?"
SUSE LINUX Products GmbH, N=FCrnberg | "Well, surrounding them's out." =


This footer brought to you by insane German lawmakers:
SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG N=FCrnberg)

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2008-03-07 14:16:09

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] [patch] make apitest more useful

Hi Stefan,

> This trivial 2-character patch makes apitest much more useful by allowing
> stuff like "apitest -l DiscoverDevices" to work like i'd expect it to:
>
> --- /usr/bin/apitest 2008-03-02 19:22:20.000000000 +0100
> +++ /home/seife/bin/apitest.seife 2008-03-06 19:44:52.000000000 +0100
> @@ -415,7 +415,7 @@ class Tester:
> self.dbus_dev_sig_setup()
> print 'Listening for events...'
>
> - elif self.cmd in mgr_cmds:
> + if self.cmd in mgr_cmds:
> try:
> self.dbus_mgr_setup()
> except dbus.DBusException, e:
>
>
> Now we can alias "hcitool scan" to "apitest -l DiscoverDevices" ;-)

the apitest is really only a test program, but I applied the patch
neverless.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel