2008-09-08 19:44:18

by Fabien Chevalier

[permalink] [raw]
Subject: [Bluez-devel] Crash bug in bluez-4.4

_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel


Attachments:
audio-plugin-crashbug-fix.diff (316.00 B)
(No filename) (363.00 B)
(No filename) (164.00 B)
Download all attachments

2008-09-08 19:59:49

by Johan Hedberg

[permalink] [raw]
Subject: Re: [Bluez-devel] Crash bug in bluez-4.4

Hi Fabien,

On Sep 8, 2008, at 22:44, Fabien Chevalier wrote:
> Path attached fixes the bug... by removing three lines of code that
> seem to me not only a premature, but also bogus optimization :-(,
> that prevent us to trying to return the first element of an empty
> gslist.
>
> However i'm not that familiar with that manager stuff and might be
> wrong, so please double check that ;-)

Good catch, and the patch looks good too. Another alternative would
have been to change the return line to
return devices ? devices->data : NULL;
but you're right in that it's just an unnecessary optimization. The
fix is now in the kernel.org git.

Johan

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel