2007-10-25 19:20:17

by Chris Rivera

[permalink] [raw]
Subject: [Bluez-devel] [PATCH] Add an ellipsis to the preferences menu item

Since the Preferences menu entry in the applet opens a new window it should
probably have an ellipsis in the label. Attached is a trivial patch to add
this.

Chris


Attachments:
(No filename) (165.00 B)
(No filename) (185.00 B)
bluez-gnome-pref-menu-item.patch (846.00 B)
(No filename) (314.00 B)
(No filename) (164.00 B)
Download all attachments

2007-10-31 16:33:57

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] [PATCH] Add an ellipsis to the preferences menu item

Hi Bastien,

> > > Since the Preferences menu entry in the applet opens a new window it
> > > should probably have an ellipsis in the label. Attached is a trivial
> > > patch to add this.
> >
> > what does the HIG recommend for applet menus. I wanna follow the HIG.
> > Currently I simply did what all other applets do that I have running.
>
> This one is a toss-up between what's right, and what GTK+ implements. It
> doesn't have separate strings for menus, so you don't get the ellipsis.
>
> I'm sure there's a GTK+ bug opened somewhere about "doing the right
> thing" in the case of stock items.
>
> So it's really up to you. Personally, I'd stick with the stock item,
> unless you have a wide-ranging amount of translations (which you'd get
> if you moved bluez-gnome to GNOME SVN, hint hint :)

I stick with the stock item. Makes stuff simpler.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2007-10-26 00:29:39

by Bastien Nocera

[permalink] [raw]
Subject: Re: [Bluez-devel] [PATCH] Add an ellipsis to the preferences menu item


On Fri, 2007-10-26 at 00:44 +0200, Marcel Holtmann wrote:
> Hi Chris,
>
> > Since the Preferences menu entry in the applet opens a new window it
> > should probably have an ellipsis in the label. Attached is a trivial
> > patch to add this.
>
> what does the HIG recommend for applet menus. I wanna follow the HIG.
> Currently I simply did what all other applets do that I have running.

This one is a toss-up between what's right, and what GTK+ implements. It
doesn't have separate strings for menus, so you don't get the ellipsis.

I'm sure there's a GTK+ bug opened somewhere about "doing the right
thing" in the case of stock items.

So it's really up to you. Personally, I'd stick with the stock item,
unless you have a wide-ranging amount of translations (which you'd get
if you moved bluez-gnome to GNOME SVN, hint hint :)


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2007-10-25 23:22:23

by Chris Rivera

[permalink] [raw]
Subject: Re: [Bluez-devel] [PATCH] Add an ellipsis to the preferences menu item

Agreed. We need to follow the HIG. According to:

http://developer.gnome.org/projects/gup/hig/hig-diff/menus-design.html

the ellipsis should be in place only if it _requires_ further input from the
user. I guess the ellipsis isn't necessary.

Chris

On 10/25/07, Marcel Holtmann <[email protected]> wrote:
>
> Hi Chris,
>
> > Since the Preferences menu entry in the applet opens a new window it
> > should probably have an ellipsis in the label. Attached is a trivial
> > patch to add this.
>
> what does the HIG recommend for applet menus. I wanna follow the HIG.
> Currently I simply did what all other applets do that I have running.
>
> Regards
>
> Marcel
>
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems? Stop.
> Now Search log events and configuration files using AJAX and a browser.
> Download your FREE copy of Splunk now >> http://get.splunk.com/
> _______________________________________________
> Bluez-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/bluez-devel
>


Attachments:
(No filename) (1.14 kB)
(No filename) (1.76 kB)
(No filename) (314.00 B)
(No filename) (164.00 B)
Download all attachments

2007-10-25 22:44:17

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] [PATCH] Add an ellipsis to the preferences menu item

Hi Chris,

> Since the Preferences menu entry in the applet opens a new window it
> should probably have an ellipsis in the label. Attached is a trivial
> patch to add this.

what does the HIG recommend for applet menus. I wanna follow the HIG.
Currently I simply did what all other applets do that I have running.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel