2007-10-11 16:13:53

by Brad Midgley

[permalink] [raw]
Subject: [Bluez-devel] sbc analysis code

Marcel,

Frederic contributed the test code he has written for evaluating the
sbc codec quality. It is GPL.

I'd like to put it in utils/sbc/sbctester.c and it would have to be
conditionally compiled and might need an extra check when it is
enabled (for libsndfile-dev). I would need your help to get the build
stuff right.

It would be cool to put optional regression tests in the build system
but it would be ok to work with it manually for now.

Does that sound ok?

Brad

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel


2007-10-18 01:59:41

by Brad Midgley

[permalink] [raw]
Subject: Re: [Bluez-devel] sbc analysis code

Marcel

This will be nice for future optimization work so I'd like to add this
to the project if there are no objections. I'll let you add the build
stuff.

Brad

> Marcel,
>
> This is updated version.
> Regards,
>
> Frederic

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2007-10-11 17:31:53

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] sbc analysis code

Hi Brad,

> > > it is currently in its own autoconf harness but I would just use the one c file.
> >
> > fix the coding style and send me a version that I can include. I will
> > take care of the aufoconf/automake magic. Don't mess around with it.
>
> hmm... indent likes to break lines. Let me know if the loops are
> nested too deeply.

I think your question already gives you my answer, but let me make it
clear, I don't wanna have too deeply nested loops. Use break and
continue or put it into separate functions.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2007-10-11 16:53:01

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] sbc analysis code

Hi Brad,

> it is currently in its own autoconf harness but I would just use the one c file.

fix the coding style and send me a version that I can include. I will
take care of the aufoconf/automake magic. Don't mess around with it.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2007-10-11 16:31:54

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] sbc analysis code

Hi Brad,

> Frederic contributed the test code he has written for evaluating the
> sbc codec quality. It is GPL.
>
> I'd like to put it in utils/sbc/sbctester.c and it would have to be
> conditionally compiled and might need an extra check when it is
> enabled (for libsndfile-dev). I would need your help to get the build
> stuff right.

can I see the code first please. So post it to the mailing list and then
I have a look at it.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel