2008-02-21 22:29:48

by Cidorvan Leite

[permalink] [raw]
Subject: [Bluez-devel] SBC optimizations

_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel


Attachments:
(No filename) (190.00 B)
sbc.patch (4.24 kB)
(No filename) (228.00 B)
(No filename) (164.00 B)
Download all attachments

2008-02-22 15:46:29

by Brad Midgley

[permalink] [raw]
Subject: Re: [Bluez-devel] SBC optimizations

Cidorvan

> "I am not sure if last version(64bits) of decode with 4 subbands is
> correct about overflows."

Some volume reduction is ok, especially if it means we avoid another overflow.

Anyway, it looks like the commit is in.

Thanks again.

--
Brad

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2008-02-22 14:19:58

by Cidorvan Leite

[permalink] [raw]
Subject: Re: [Bluez-devel] SBC optimizations

Hi Brad!

I would say:
"I am not sure if last version(64bits) of decode with 4 subbands is
correct about overflows."

On Fri, Feb 22, 2008 at 11:00 AM, Cidorvan Leite <[email protected]> wrote:
> Hi Brad!
>
> The volume drop is not significant.
> Comparing the versions, I didn't see any change in quality with my
> headphone, so I think that we can change to 32bits.
> By the way, I am not sure if last version of decode with 4 subbands is
> correct about overflows.
>
>
>
> On Thu, Feb 21, 2008 at 10:58 PM, Brad Midgley <[email protected]> wrote:
> > Cidorvan
> >
> > How significant is the volume drop in 4 subbands? Should we just leave
> > the decoder at 64 bit mults so we don't needlessly suffer quality
> > issues on faster platforms?
> >
> > Brad
> >
> >
> >
> > On Thu, Feb 21, 2008 at 3:29 PM, Cidorvan Leite <[email protected]> wrote:
> > > Hi!
> > >
> > > I replaced the 64bits multiplies by 32bits and fixed the volume, now
> > > the encode and decode are >10% faster.
> > > Unfortunately, I couldn't keep the same volume for decode with 4 subbands...
> > >
> > > -------------------------------------------------------------------------
> > > This SF.net email is sponsored by: Microsoft
> > > Defy all challenges. Microsoft(R) Visual Studio 2008.
> > > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> > > _______________________________________________
> > > Bluez-devel mailing list
> > > [email protected]
> > > https://lists.sourceforge.net/lists/listinfo/bluez-devel
> > >
> > >
> >
> >
> >
> > --
> > Brad
> >
> > -------------------------------------------------------------------------
> > This SF.net email is sponsored by: Microsoft
> > Defy all challenges. Microsoft(R) Visual Studio 2008.
> > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> > _______________________________________________
> > Bluez-devel mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/bluez-devel
> >
>

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2008-02-22 14:00:50

by Cidorvan Leite

[permalink] [raw]
Subject: Re: [Bluez-devel] SBC optimizations

Hi Brad!

The volume drop is not significant.
Comparing the versions, I didn't see any change in quality with my
headphone, so I think that we can change to 32bits.
By the way, I am not sure if last version of decode with 4 subbands is
correct about overflows.

On Thu, Feb 21, 2008 at 10:58 PM, Brad Midgley <[email protected]> wrote:
> Cidorvan
>
> How significant is the volume drop in 4 subbands? Should we just leave
> the decoder at 64 bit mults so we don't needlessly suffer quality
> issues on faster platforms?
>
> Brad
>
>
>
> On Thu, Feb 21, 2008 at 3:29 PM, Cidorvan Leite <[email protected]> wrote:
> > Hi!
> >
> > I replaced the 64bits multiplies by 32bits and fixed the volume, now
> > the encode and decode are >10% faster.
> > Unfortunately, I couldn't keep the same volume for decode with 4 subbands...
> >
> > -------------------------------------------------------------------------
> > This SF.net email is sponsored by: Microsoft
> > Defy all challenges. Microsoft(R) Visual Studio 2008.
> > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> > _______________________________________________
> > Bluez-devel mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/bluez-devel
> >
> >
>
>
>
> --
> Brad
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Bluez-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/bluez-devel
>

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2008-02-22 01:58:26

by Brad Midgley

[permalink] [raw]
Subject: Re: [Bluez-devel] SBC optimizations

Cidorvan

How significant is the volume drop in 4 subbands? Should we just leave
the decoder at 64 bit mults so we don't needlessly suffer quality
issues on faster platforms?

Brad

On Thu, Feb 21, 2008 at 3:29 PM, Cidorvan Leite <[email protected]> wrote:
> Hi!
>
> I replaced the 64bits multiplies by 32bits and fixed the volume, now
> the encode and decode are >10% faster.
> Unfortunately, I couldn't keep the same volume for decode with 4 subbands...
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Bluez-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/bluez-devel
>
>



--
Brad

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel