2017-01-11 18:37:26

by Rob Rice

[permalink] [raw]
Subject: arm64 broken

I’m working on updating a patchset. The master branch in crypto-2.6 doesn’t compile for ARM64. The first couple errors are listed below. A colleague believes that the following commit in rc2 fixes the problem.

commit b4b8664d291ac1998e0f0bcdc96b6397f0fe68b3
Author: Al Viro <[email protected] <mailto:[email protected]>>
Date: Mon Dec 26 04:10:19 2016 -0500

arm64: don't pull uaccess.h into *.S

Split asm-only parts of arm64 uaccess.h into a new header and use that
from *.S.

Signed-off-by: Al Viro <[email protected] <mailto:[email protected]>>

Any chance we could either pull in the fix or move to rc2?

Thanks,

Rob


AS arch/arm64/kernel/entry.o
In file included from ./include/linux/sched.h:17:0,
from ./include/linux/uaccess.h:4,
from arch/arm64/kernel/entry.S:34:
./include/linux/kernel.h:49:0: warning: "ALIGN" redefined
#define ALIGN(x, a) __ALIGN_KERNEL((x), (a))
^
In file included from arch/arm64/kernel/entry.S:22:0:
./include/linux/linkage.h:78:0: note: this is the location of the previous definition
#define ALIGN __ALIGN
^
In file included from ./include/linux/time.h:7:0,
from ./include/uapi/linux/timex.h:56,
from ./include/linux/timex.h:56,
from ./include/linux/sched.h:19,
from ./include/linux/uaccess.h:4,
from arch/arm64/kernel/entry.S:34:
./include/linux/time64.h:36:0: warning: "NSEC_PER_SEC" redefined
#define NSEC_PER_SEC 1000000000L


2017-01-12 07:50:52

by Herbert Xu

[permalink] [raw]
Subject: Re: arm64 broken

Rob Rice <[email protected]> wrote:
> I’m working on updating a patchset. The master branch in crypto-2.6 doesn’t compile for ARM64. The first couple errors are listed below. A colleague believes that the following commit in rc2 fixes the problem.

I presume you mean cryptodev and not crypto.

> commit b4b8664d291ac1998e0f0bcdc96b6397f0fe68b3
> Author: Al Viro <[email protected] <mailto:[email protected]>>
> Date: Mon Dec 26 04:10:19 2016 -0500
>
> arm64: don't pull uaccess.h into *.S
>
> Split asm-only parts of arm64 uaccess.h into a new header and use that
> from *.S.
>
> Signed-off-by: Al Viro <[email protected] <mailto:[email protected]>>
>
> Any chance we could either pull in the fix or move to rc2?

Sure I'll pull it in.

Cheers,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt