2021-04-02 09:59:03

by Meng Yu

Subject: [PATCH] ecc: delete a useless function declaration

This function declaration has been added in 'ecc_curve.h',
delete it in 'crypto/ecc.h'.

Fixes: 14bb76768275(crypto: ecc - expose ecc curves)
Signed-off-by: Meng Yu <[email protected]>
---
crypto/ecc.h | 8 --------
1 file changed, 8 deletions(-)

diff --git a/crypto/ecc.h b/crypto/ecc.h
index 46aa9bc..a006132 100644
--- a/crypto/ecc.h
+++ b/crypto/ecc.h
@@ -56,14 +56,6 @@ static inline void ecc_swap_digits(const u64 *in, u64 *out, unsigned int ndigits
}

/**
- * ecc_get_curve() - Get a curve given its curve_id
- * @curve_id: Id of the curve
- *
- * Returns pointer to the curve data, NULL if curve is not available
- */
-const struct ecc_curve *ecc_get_curve(unsigned int curve_id);
-
-/**
* ecc_is_key_valid() - Validate a given ECDH private key
*
* @curve_id: id representing the curve to use
--
2.8.1

2021-04-02 10:35:24

by Christophe Leroy

Subject: Re: [PATCH] ecc: delete a useless function declaration

Le 02/04/2021 à 11:55, Meng Yu a écrit :
> This function declaration has been added in 'ecc_curve.h',
> delete it in 'crypto/ecc.h'.
>
> Fixes: 14bb76768275(crypto: ecc - expose ecc curves)

Fixes tag is wrong I think, should be 4e6602916bc6

> Signed-off-by: Meng Yu <[email protected]>
> ---
> crypto/ecc.h | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/crypto/ecc.h b/crypto/ecc.h
> index 46aa9bc..a006132 100644
> --- a/crypto/ecc.h
> +++ b/crypto/ecc.h
> @@ -56,14 +56,6 @@ static inline void ecc_swap_digits(const u64 *in, u64 *out, unsigned int ndigits
> }
>
> /**
> - * ecc_get_curve() - Get a curve given its curve_id
> - * @curve_id: Id of the curve
> - *
> - * Returns pointer to the curve data, NULL if curve is not available
> - */
> -const struct ecc_curve *ecc_get_curve(unsigned int curve_id);
> -
> -/**
> * ecc_is_key_valid() - Validate a given ECDH private key
> *
> * @curve_id: id representing the curve to use
>

2021-04-06 11:35:13

by Meng Yu

Subject: Re: [PATCH] ecc: delete a useless function declaration

在 2021/4/2 18:34, Christophe Leroy 写道:
>
>
> Le 02/04/2021 à 11:55, Meng Yu a écrit :
>> This function declaration has been added in 'ecc_curve.h',
>> delete it in 'crypto/ecc.h'.
>>
>> Fixes: 14bb76768275(crypto: ecc - expose ecc curves)
>
> Fixes tag is wrong I think, should be 4e6602916bc6
>

Yes, you are right, thank you.

>> Signed-off-by: Meng Yu <[email protected]>
>> ---
>>   crypto/ecc.h | 8 --------
>>   1 file changed, 8 deletions(-)
>>
>> diff --git a/crypto/ecc.h b/crypto/ecc.h
>> index 46aa9bc..a006132 100644
>> --- a/crypto/ecc.h
>> +++ b/crypto/ecc.h
>> @@ -56,14 +56,6 @@ static inline void ecc_swap_digits(const u64 *in,
>> u64 *out, unsigned int ndigits
>>   }
>>   /**
>> - * ecc_get_curve()  - Get a curve given its curve_id
>> - * @curve_id:  Id of the curve
>> - *
>> - * Returns pointer to the curve data, NULL if curve is not available
>> - */
>> -const struct ecc_curve *ecc_get_curve(unsigned int curve_id);
>> -
>> -/**
>>    * ecc_is_key_valid() - Validate a given ECDH private key
>>    *
>>    * @curve_id:        id representing the curve to use
>>
> .