2008-09-06 14:42:59

by Herbert Xu

[permalink] [raw]
Subject: Re: Camellia encryption module: incompatible

On Sat, Sep 06, 2008 at 02:44:49PM +0200, Carlo E. Prelz wrote:
> Hello there. I see you are the person who pushed upwards changes
> related to the Linux crypto susbsystem for 2.6.27. I wanted to let you
> know that, on a Core2 laptop platform, the new code for the Camellia
> module generates different encrypted content. Both implementations
> work, but a file that was encrypted with pre-2.6.27 cannot be
> decrypted with the current code.
>
> Was this intentional? I saw no indication about this on the notes that
> went with the patch.

No this is not intentional. Thanks for reminding me.

Harvey, I think I'm going to revert the bitops change for now.

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


2008-09-06 21:02:50

by Carlo E. Prelz

[permalink] [raw]
Subject: Re: Camellia encryption module: incompatible

Subject: Re: Camellia encryption module: incompatible
Date: dom 07 set 08 12:42:50 +1000

Quoting Herbert Xu ([email protected]):

> No this is not intentional. Thanks for reminding me.

Thank you all for all the work that goes into maintaining Linux...

> Harvey, I think I'm going to revert the bitops change for now.

I will be glad to verify that all is OK as soon as the change
percolates into a 2.6.27-rc patch.

Carlo

--
* Se la Strada e la sua Virtu' non fossero state messe da parte,
* K * Carlo E. Prelz - [email protected] che bisogno ci sarebbe
* di parlare tanto di amore e di rettitudine? (Chuang-Tzu)

2008-09-07 19:55:39

by Harvey Harrison

[permalink] [raw]
Subject: Re: Camellia encryption module: incompatible

On Sun, 2008-09-07 at 00:42 +1000, Herbert Xu wrote:
> On Sat, Sep 06, 2008 at 02:44:49PM +0200, Carlo E. Prelz wrote:
> > Hello there. I see you are the person who pushed upwards changes
> > related to the Linux crypto susbsystem for 2.6.27. I wanted to let you
> > know that, on a Core2 laptop platform, the new code for the Camellia
> > module generates different encrypted content. Both implementations
> > work, but a file that was encrypted with pre-2.6.27 cannot be
> > decrypted with the current code.
> >
> > Was this intentional? I saw no indication about this on the notes that
> > went with the patch.
>
> No this is not intentional. Thanks for reminding me.
>
> Harvey, I think I'm going to revert the bitops change for now.
>

Please do, I still haven't managed to to track down why this changes
any behavior, I'll resubmit at a later date if I ever figure it out.

Harvey


2008-09-10 14:57:51

by Carlo E. Prelz

[permalink] [raw]
Subject: Re: Camellia encryption module: incompatible

Subject: Re: Camellia encryption module: incompatible
Date: dom 07 set 08 12:55:42 -0700

Quoting Harvey Harrison ([email protected]):

> > > Was this intentional? I saw no indication about this on the notes that
> > > went with the patch.
> >
> > No this is not intentional. Thanks for reminding me.
> >
> > Harvey, I think I'm going to revert the bitops change for now.
> >
>
> Please do, I still haven't managed to to track down why this changes
> any behavior, I'll resubmit at a later date if I ever figure it out.

I can confirm that, with 2.6.27-rc6, my camellia-encrypted partition
mounts cleanly once more.

Thanks

Carlo

--
* Se la Strada e la sua Virtu' non fossero state messe da parte,
* K * Carlo E. Prelz - [email protected] che bisogno ci sarebbe
* di parlare tanto di amore e di rettitudine? (Chuang-Tzu)