2019-03-30 01:35:13

by Yue Haibing

Subject: [PATCH -next] crypto: ccp - Use kmemdup in ccp_copy_and_save_keypart()

Use kmemdup rather than duplicating its implementation

Signed-off-by: YueHaibing <[email protected]>
---
drivers/crypto/ccp/ccp-crypto-rsa.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/crypto/ccp/ccp-crypto-rsa.c b/drivers/crypto/ccp/ccp-crypto-rsa.c
index 0b8aab009e7b..841acdffbc3c 100644
--- a/drivers/crypto/ccp/ccp-crypto-rsa.c
+++ b/drivers/crypto/ccp/ccp-crypto-rsa.c
@@ -37,10 +37,9 @@ static inline int ccp_copy_and_save_keypart(u8 **kpbuf, unsigned int *kplen,
if (buf[nskip])
break;
*kplen = sz - nskip;
- *kpbuf = kzalloc(*kplen, GFP_KERNEL);
+ *kpbuf = kmemdup(buf + nskip, *kplen, GFP_KERNEL);
if (!*kpbuf)
return -ENOMEM;
- memcpy(*kpbuf, buf + nskip, *kplen);

return 0;
}

2019-04-01 13:27:32

by Gary R Hook

Subject: Re: [PATCH -next] crypto: ccp - Use kmemdup in ccp_copy_and_save_keypart()

On 3/29/19 8:43 PM, YueHaibing wrote:
> Use kmemdup rather than duplicating its implementation
>
> Signed-off-by: YueHaibing <[email protected]>

Acked-by: Gary R Hook <[email protected]>

> ---
> drivers/crypto/ccp/ccp-crypto-rsa.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/ccp/ccp-crypto-rsa.c b/drivers/crypto/ccp/ccp-crypto-rsa.c
> index 0b8aab009e7b..841acdffbc3c 100644
> --- a/drivers/crypto/ccp/ccp-crypto-rsa.c
> +++ b/drivers/crypto/ccp/ccp-crypto-rsa.c
> @@ -37,10 +37,9 @@ static inline int ccp_copy_and_save_keypart(u8 **kpbuf, unsigned int *kplen,
> if (buf[nskip])
> break;
> *kplen = sz - nskip;
> - *kpbuf = kzalloc(*kplen, GFP_KERNEL);
> + *kpbuf = kmemdup(buf + nskip, *kplen, GFP_KERNEL);
> if (!*kpbuf)
> return -ENOMEM;
> - memcpy(*kpbuf, buf + nskip, *kplen);
>
> return 0;
> }
>
>
>

2019-04-08 06:40:59

by Herbert Xu

Subject: Re: [PATCH -next] crypto: ccp - Use kmemdup in ccp_copy_and_save_keypart()

On Sat, Mar 30, 2019 at 01:43:16AM +0000, YueHaibing wrote:
> Use kmemdup rather than duplicating its implementation
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/crypto/ccp/ccp-crypto-rsa.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt