2013-02-26 16:04:50

by Joel A Fernandes

Subject: [PATCH v3 1/2] omap-sham: Use pm_runtime_put instead of pm_runtime_put_sync in tasklet

From: Joel A Fernandes <[email protected]>

After DMA is complete, the omap_sham_finish_req function is called as
a part of the done_task tasklet. During this its atomic and any calls
to pm functions should not assume they wont sleep.

The patch replaces a call to pm_runtime_put_sync (which can sleep) with
pm_runtime_put thus fixing a kernel panic observed on AM33xx SoC during
SHA operation.

Tested on an AM33xx SoC device (beaglebone board).
To reproduce the problem, used the tcrypt kernel module as:
modprobe tcrypt sec=2 mode=403

Signed-off-by: Joel A Fernandes <[email protected]>
Cc: Herbert Xu <[email protected]>
Cc: David S. Miller <[email protected]>
Cc: Mark A. Greer <[email protected]>
---
drivers/crypto/omap-sham.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
index edff981..b8bb583 100644
--- a/drivers/crypto/omap-sham.c
+++ b/drivers/crypto/omap-sham.c
@@ -923,7 +923,7 @@ static void omap_sham_finish_req(struct ahash_request *req, int err)
dd->flags &= ~(BIT(FLAGS_BUSY) | BIT(FLAGS_FINAL) | BIT(FLAGS_CPU) |
BIT(FLAGS_DMA_READY) | BIT(FLAGS_OUTPUT_READY));

- pm_runtime_put_sync(dd->dev);
+ pm_runtime_put(dd->dev);

if (req->base.complete)
req->base.complete(&req->base, err);
--
1.7.4.1

2013-02-26 16:04:53

by Joel A Fernandes

Subject: [PATCH v3 2/2] omap-aes: Use pm_runtime_put instead of pm_runtime_put_sync in tasklet

From: Joel A Fernandes <[email protected]>

After DMA is complete, the omap_aes_finish_req function is called as
a part of the done_task tasklet. During this its atomic and any calls
to pm functions should not assume they wont sleep.

The patch replaces a call to pm_runtime_put_sync (which can sleep) with
pm_runtime_put thus fixing a kernel panic observed on AM33xx SoC during
AES operation.

Tested on an AM33xx SoC device (beaglebone board).
To reproduce the problem, I used the tcrypt kernel module as:
modprobe tcrypt sec=2 mode=500

Signed-off-by: Joel A Fernandes <[email protected]>
Cc: Herbert Xu <[email protected]>
Cc: David S. Miller <[email protected]>
Cc: Mark A. Greer <[email protected]>
---
drivers/crypto/omap-aes.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
index cf57866..8450bfd2 100644
--- a/drivers/crypto/omap-aes.c
+++ b/drivers/crypto/omap-aes.c
@@ -636,7 +636,7 @@ static void omap_aes_finish_req(struct omap_aes_dev *dd, int err)

pr_debug("err: %d\n", err);

- pm_runtime_put_sync(dd->dev);
+ pm_runtime_put(dd->dev);
dd->flags &= ~FLAGS_BUSY;

req->base.complete(&req->base, err);
--
1.7.4.1

2013-02-26 23:06:14

by Mark Greer

Subject: Re: [PATCH v3 1/2] omap-sham: Use pm_runtime_put instead of pm_runtime_put_sync in tasklet

On Tue, Feb 26, 2013 at 10:04:31AM -0600, [email protected] wrote:
> From: Joel A Fernandes <[email protected]>
>
> After DMA is complete, the omap_sham_finish_req function is called as
> a part of the done_task tasklet. During this its atomic and any calls
> to pm functions should not assume they wont sleep.
>
> The patch replaces a call to pm_runtime_put_sync (which can sleep) with
> pm_runtime_put thus fixing a kernel panic observed on AM33xx SoC during
> SHA operation.
>
> Tested on an AM33xx SoC device (beaglebone board).
> To reproduce the problem, used the tcrypt kernel module as:
> modprobe tcrypt sec=2 mode=403
>
> Signed-off-by: Joel A Fernandes <[email protected]>
> Cc: Herbert Xu <[email protected]>
> Cc: David S. Miller <[email protected]>
> Cc: Mark A. Greer <[email protected]>
> ---
> drivers/crypto/omap-sham.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
> index edff981..b8bb583 100644
> --- a/drivers/crypto/omap-sham.c
> +++ b/drivers/crypto/omap-sham.c
> @@ -923,7 +923,7 @@ static void omap_sham_finish_req(struct ahash_request *req, int err)
> dd->flags &= ~(BIT(FLAGS_BUSY) | BIT(FLAGS_FINAL) | BIT(FLAGS_CPU) |
> BIT(FLAGS_DMA_READY) | BIT(FLAGS_OUTPUT_READY));
>
> - pm_runtime_put_sync(dd->dev);
> + pm_runtime_put(dd->dev);
>
> if (req->base.complete)
> req->base.complete(&req->base, err);

Acked-by: Mark A. Greer <[email protected]>

2013-02-26 23:06:37

by Mark Greer

Subject: Re: [PATCH v3 2/2] omap-aes: Use pm_runtime_put instead of pm_runtime_put_sync in tasklet

On Tue, Feb 26, 2013 at 10:04:32AM -0600, [email protected] wrote:
> From: Joel A Fernandes <[email protected]>
>
> After DMA is complete, the omap_aes_finish_req function is called as
> a part of the done_task tasklet. During this its atomic and any calls
> to pm functions should not assume they wont sleep.
>
> The patch replaces a call to pm_runtime_put_sync (which can sleep) with
> pm_runtime_put thus fixing a kernel panic observed on AM33xx SoC during
> AES operation.
>
> Tested on an AM33xx SoC device (beaglebone board).
> To reproduce the problem, I used the tcrypt kernel module as:
> modprobe tcrypt sec=2 mode=500
>
> Signed-off-by: Joel A Fernandes <[email protected]>
> Cc: Herbert Xu <[email protected]>
> Cc: David S. Miller <[email protected]>
> Cc: Mark A. Greer <[email protected]>
> ---
> drivers/crypto/omap-aes.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
> index cf57866..8450bfd2 100644
> --- a/drivers/crypto/omap-aes.c
> +++ b/drivers/crypto/omap-aes.c
> @@ -636,7 +636,7 @@ static void omap_aes_finish_req(struct omap_aes_dev *dd, int err)
>
> pr_debug("err: %d\n", err);
>
> - pm_runtime_put_sync(dd->dev);
> + pm_runtime_put(dd->dev);
> dd->flags &= ~FLAGS_BUSY;
>
> req->base.complete(&req->base, err);

Acked-by: Mark A. Greer <[email protected]>

2013-03-10 10:15:39

by Herbert Xu

Subject: Re: [PATCH v3 2/2] omap-aes: Use pm_runtime_put instead of pm_runtime_put_sync in tasklet

On Tue, Feb 26, 2013 at 04:06:36PM -0700, Mark A. Greer wrote:
> On Tue, Feb 26, 2013 at 10:04:32AM -0600, [email protected] wrote:
> > From: Joel A Fernandes <[email protected]>
> >
> > After DMA is complete, the omap_aes_finish_req function is called as
> > a part of the done_task tasklet. During this its atomic and any calls
> > to pm functions should not assume they wont sleep.
> >
> > The patch replaces a call to pm_runtime_put_sync (which can sleep) with
> > pm_runtime_put thus fixing a kernel panic observed on AM33xx SoC during
> > AES operation.
> >
> > Tested on an AM33xx SoC device (beaglebone board).
> > To reproduce the problem, I used the tcrypt kernel module as:
> > modprobe tcrypt sec=2 mode=500
> >
> > Signed-off-by: Joel A Fernandes <[email protected]>
> > Cc: Herbert Xu <[email protected]>
> > Cc: David S. Miller <[email protected]>
> > Cc: Mark A. Greer <[email protected]>
> > ---
> > drivers/crypto/omap-aes.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
> > index cf57866..8450bfd2 100644
> > --- a/drivers/crypto/omap-aes.c
> > +++ b/drivers/crypto/omap-aes.c
> > @@ -636,7 +636,7 @@ static void omap_aes_finish_req(struct omap_aes_dev *dd, int err)
> >
> > pr_debug("err: %d\n", err);
> >
> > - pm_runtime_put_sync(dd->dev);
> > + pm_runtime_put(dd->dev);
> > dd->flags &= ~FLAGS_BUSY;
> >
> > req->base.complete(&req->base, err);
>
> Acked-by: Mark A. Greer <[email protected]>

Both patches applied. Thanks!
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt