2013-12-21 07:25:48

by Sachin Kamat

Subject: [PATCH 1/3] crypto: crypto4xx_core: Remove redundant dev_set_drvdata

Driver core sets it to NULL upon probe failure or release.

Signed-off-by: Sachin Kamat <[email protected]>
---
drivers/crypto/amcc/crypto4xx_core.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/crypto/amcc/crypto4xx_core.c b/drivers/crypto/amcc/crypto4xx_core.c
index efaf6302405f..37f9cc98ba17 100644
--- a/drivers/crypto/amcc/crypto4xx_core.c
+++ b/drivers/crypto/amcc/crypto4xx_core.c
@@ -724,7 +724,6 @@ static void crypto4xx_stop_all(struct crypto4xx_core_device *core_dev)
crypto4xx_destroy_pdr(core_dev->dev);
crypto4xx_destroy_gdr(core_dev->dev);
crypto4xx_destroy_sdr(core_dev->dev);
- dev_set_drvdata(core_dev->device, NULL);
iounmap(core_dev->dev->ce_base);
kfree(core_dev->dev);
kfree(core_dev);
--
1.7.9.5

2013-12-21 07:25:50

by Sachin Kamat

Subject: [PATCH 2/3] crypto: ccp-pci: Remove redundant dev_set_drvdata

Driver core sets it to NULL upon probe failure or release.

Signed-off-by: Sachin Kamat <[email protected]>
---
drivers/crypto/ccp/ccp-pci.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/crypto/ccp/ccp-pci.c b/drivers/crypto/ccp/ccp-pci.c
index 1fbeaf1856a8..f08c16d370cd 100644
--- a/drivers/crypto/ccp/ccp-pci.c
+++ b/drivers/crypto/ccp/ccp-pci.c
@@ -247,7 +247,6 @@ e_bar0:

e_device:
pci_disable_device(pdev);
- dev_set_drvdata(dev, NULL);

e_regions:
pci_release_regions(pdev);
@@ -273,7 +272,6 @@ static void ccp_pci_remove(struct pci_dev *pdev)
pci_iounmap(pdev, ccp->io_map);

pci_disable_device(pdev);
- dev_set_drvdata(dev, NULL);

pci_release_regions(pdev);

--
1.7.9.5

2013-12-21 07:25:53

by Sachin Kamat

Subject: [PATCH 3/3] crypto: talitos: Remove redundant dev_set_drvdata

Driver core sets it to NULL upon probe failure or release.

Signed-off-by: Sachin Kamat <[email protected]>
---
drivers/crypto/talitos.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
index a3d2e9b88c41..5967667e1a8f 100644
--- a/drivers/crypto/talitos.c
+++ b/drivers/crypto/talitos.c
@@ -2495,8 +2495,6 @@ static int talitos_remove(struct platform_device *ofdev)

iounmap(priv->reg);

- dev_set_drvdata(dev, NULL);
-
kfree(priv);

return 0;
--
1.7.9.5

2013-12-30 12:20:09

by Herbert Xu

Subject: Re: [PATCH 1/3] crypto: crypto4xx_core: Remove redundant dev_set_drvdata

On Sat, Dec 21, 2013 at 12:52:28PM +0530, Sachin Kamat wrote:
> Driver core sets it to NULL upon probe failure or release.
>
> Signed-off-by: Sachin Kamat <[email protected]>

All applied. Thanks!
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt