2014-12-05 05:38:51

by Joshua I. James

Subject: [PATCH] staging: crypto: fixed style error in af_alg.c

From: "Joshua I. James" <[email protected]>

Fixed style error identified by checkpatch.

ERROR: space required before the open parenthesis '('
+ switch(cmsg->cmsg_type) {

Signed-off-by: Joshua I. James <[email protected]>
---
crypto/af_alg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/af_alg.c b/crypto/af_alg.c
index 6a3ad80..b01deb4 100644
--- a/crypto/af_alg.c
+++ b/crypto/af_alg.c
@@ -405,7 +405,7 @@ int af_alg_cmsg_send(struct msghdr *msg, struct af_alg_control *con)
if (cmsg->cmsg_level != SOL_ALG)
continue;

- switch(cmsg->cmsg_type) {
+ switch (cmsg->cmsg_type) {
case ALG_SET_IV:
if (cmsg->cmsg_len < CMSG_LEN(sizeof(*con->iv)))
return -EINVAL;
--
1.9.1

2014-12-05 13:53:17

by Jason Cooper

Subject: Re: [PATCH] staging: crypto: fixed style error in af_alg.c

On Fri, Dec 05, 2014 at 02:38:40PM +0900, Joshua I. James wrote:
> From: "Joshua I. James" <[email protected]>
>
> Fixed style error identified by checkpatch.
>
> ERROR: space required before the open parenthesis '('
> + switch(cmsg->cmsg_type) {
>
> Signed-off-by: Joshua I. James <[email protected]>
> ---
> crypto/af_alg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Subject line, and this change really doesn't justify a patch by itself.
If Herbert prefers them merged into one, I'd include this change,
otherwise, I'd drop it.

It'd also be a good idea to run ./scripts/get_maintainer.pl on your
patch to determine who to include in the To/Cc on the next version of
this series.

thx,

Jason.