2015-10-07 17:39:44

by Alexander Kuleshov

Subject: [PATCH] crypto/jitterentropy-kcapi: fix a comment reflecting function name changed

The clocksource does not provide clocksource_register() function since
f893598 commit (clocksource: Mostly kill clocksource_register()), but
__clocksource_register() instead.

Signed-off-by: Alexander Kuleshov <[email protected]>
---
crypto/jitterentropy-kcapi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/jitterentropy-kcapi.c b/crypto/jitterentropy-kcapi.c
index ceea83d..4b030df 100644
--- a/crypto/jitterentropy-kcapi.c
+++ b/crypto/jitterentropy-kcapi.c
@@ -101,7 +101,7 @@ void jent_get_nstime(__u64 *out)
*
* The list of available timers can be obtained from
* /sys/devices/system/clocksource/clocksource0/available_clocksource
- * and are registered with clocksource_register()
+ * and are registered with __clocksource_register()
*/
if ((0 == tmp) &&
(0 == __getnstimeofday(&ts))) {
--
2.6.0

2015-10-08 13:28:44

by Herbert Xu

Subject: Re: [PATCH] crypto/jitterentropy-kcapi: fix a comment reflecting function name changed

On Wed, Oct 07, 2015 at 11:38:14PM +0600, Alexander Kuleshov wrote:
> The clocksource does not provide clocksource_register() function since
> f893598 commit (clocksource: Mostly kill clocksource_register()), but
> __clocksource_register() instead.
>
> Signed-off-by: Alexander Kuleshov <[email protected]>
> ---
> crypto/jitterentropy-kcapi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/crypto/jitterentropy-kcapi.c b/crypto/jitterentropy-kcapi.c
> index ceea83d..4b030df 100644
> --- a/crypto/jitterentropy-kcapi.c
> +++ b/crypto/jitterentropy-kcapi.c
> @@ -101,7 +101,7 @@ void jent_get_nstime(__u64 *out)
> *
> * The list of available timers can be obtained from
> * /sys/devices/system/clocksource/clocksource0/available_clocksource
> - * and are registered with clocksource_register()
> + * and are registered with __clocksource_register()

Please get rid of the reference to clocksource_register altogether.
It's simply unnecessary.

Cheers,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt