2016-01-17 09:03:35

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH 4/4] hw_random: brcm63xx-rng: document device tree bindings

Documents device tree bindings for random number generator present on Broadcom
BCM6368 SoC.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
---
Documentation/devicetree/bindings/rng/brcm,bcm6368.txt | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
create mode 100644 Documentation/devicetree/bindings/rng/brcm,bcm6368.txt

diff --git a/Documentation/devicetree/bindings/rng/brcm,bcm6368.txt b/Documentation/devicetree/bindings/rng/brcm,bcm6368.txt
new file mode 100644
index 0000000..4b5ac60
--- /dev/null
+++ b/Documentation/devicetree/bindings/rng/brcm,bcm6368.txt
@@ -0,0 +1,17 @@
+BCM6368 Random number generator
+
+Required properties:
+
+- compatible : should be "brcm,bcm6368-rng"
+- reg : Specifies base physical address and size of the registers
+- clocks : phandle to clock-controller plus clock-specifier pair
+- clock-names : "ipsec" as a clock name
+
+Example:
+ random: rng@10004180 {
+ compatible = "brcm,bcm6368-rng";
+ reg = <0x10004180 0x14>;
+
+ clocks = <&periph_clk 18>;
+ clock-names = "ipsec";
+ };
--
1.9.1


2016-01-18 19:11:50

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 4/4] hw_random: brcm63xx-rng: document device tree bindings

Le 17/01/2016 01:03, Álvaro Fernández Rojas a écrit :
> Documents device tree bindings for random number generator present on Broadcom
> BCM6368 SoC.
>
> Signed-off-by: Álvaro Fernández Rojas <[email protected]>

Reviewed-by: Florian Fainelli <[email protected]>

I could not track down the proper versioning of this IP block, so this
is a good choice, thanks!

Nit: it is kind of nice to re-order the binding addition to come before
the driver and/or driver conversion to Device Tree probing.
--
Florian

2016-01-20 17:20:25

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH 4/4] hw_random: brcm63xx-rng: document device tree bindings

On Sun, Jan 17, 2016 at 10:03:57AM +0100, ?lvaro Fern?ndez Rojas wrote:
> Documents device tree bindings for random number generator present on Broadcom
> BCM6368 SoC.
>
> Signed-off-by: ?lvaro Fern?ndez Rojas <[email protected]>
> ---
> Documentation/devicetree/bindings/rng/brcm,bcm6368.txt | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rng/brcm,bcm6368.txt

Acked-by: Rob Herring <[email protected]>