2016-07-18 09:32:59

by Romain Perier

Subject: [PATCH] crypto: marvell: Fix wrong flag used for GFP in mv_cesa_dma_add_iv_op

Use the parameter 'gfp_flags' instead of 'flag' as second argument of
dma_pool_alloc(). The parameter 'flag' is for the TDMA descriptor, its
content has no sense for the allocator.

Signed-off-by: Romain Perier <[email protected]>
---
drivers/crypto/marvell/tdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/marvell/tdma.c b/drivers/crypto/marvell/tdma.c
index 942f4b6..51a631d 100644
--- a/drivers/crypto/marvell/tdma.c
+++ b/drivers/crypto/marvell/tdma.c
@@ -223,7 +223,7 @@ int mv_cesa_dma_add_iv_op(struct mv_cesa_tdma_chain *chain, dma_addr_t src,
if (IS_ERR(tdma))
return PTR_ERR(tdma);

- iv = dma_pool_alloc(cesa_dev->dma->iv_pool, flags, &dma_handle);
+ iv = dma_pool_alloc(cesa_dev->dma->iv_pool, gfp_flags, &dma_handle);
if (!iv)
return -ENOMEM;

--
2.8.1

2016-07-18 10:00:59

by Boris Brezillon

Subject: Re: [PATCH] crypto: marvell: Fix wrong flag used for GFP in mv_cesa_dma_add_iv_op

On Mon, 18 Jul 2016 11:32:24 +0200
Romain Perier <[email protected]> wrote:

> Use the parameter 'gfp_flags' instead of 'flag' as second argument of
> dma_pool_alloc(). The parameter 'flag' is for the TDMA descriptor, its
> content has no sense for the allocator.
>
> Signed-off-by: Romain Perier <[email protected]>

Acked-by: Boris Brezillon <[email protected]>

Herbert, can you add the following line when applying then patch?

Fixes: bac8e805a30d ("crypto: marvell - Copy IV vectors by DMA transfers for acipher requests")

> ---
> drivers/crypto/marvell/tdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/marvell/tdma.c b/drivers/crypto/marvell/tdma.c
> index 942f4b6..51a631d 100644
> --- a/drivers/crypto/marvell/tdma.c
> +++ b/drivers/crypto/marvell/tdma.c
> @@ -223,7 +223,7 @@ int mv_cesa_dma_add_iv_op(struct mv_cesa_tdma_chain *chain, dma_addr_t src,
> if (IS_ERR(tdma))
> return PTR_ERR(tdma);
>
> - iv = dma_pool_alloc(cesa_dev->dma->iv_pool, flags, &dma_handle);
> + iv = dma_pool_alloc(cesa_dev->dma->iv_pool, gfp_flags, &dma_handle);
> if (!iv)
> return -ENOMEM;
>

2016-07-19 07:45:03

by Herbert Xu

Subject: Re: [PATCH] crypto: marvell: Fix wrong flag used for GFP in mv_cesa_dma_add_iv_op

Boris Brezillon <[email protected]> wrote:
> On Mon, 18 Jul 2016 11:32:24 +0200
> Romain Perier <[email protected]> wrote:
>
>> Use the parameter 'gfp_flags' instead of 'flag' as second argument of
>> dma_pool_alloc(). The parameter 'flag' is for the TDMA descriptor, its
>> content has no sense for the allocator.
>>
>> Signed-off-by: Romain Perier <[email protected]>
>
> Acked-by: Boris Brezillon <[email protected]>
>
> Herbert, can you add the following line when applying then patch?
>
> Fixes: bac8e805a30d ("crypto: marvell - Copy IV vectors by DMA transfers for acipher requests")

Patch applied with the fixes tag.

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt