2016-08-22 16:11:44

by Wei Yongjun

Subject: [PATCH -next] chcr: Fix non static symbol warning

From: Wei Yongjun <[email protected]>

Fixes the following sparse warning:

drivers/crypto/chelsio/chcr_algo.c:593:5: warning:
symbol 'cxgb4_is_crypto_q_full' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/crypto/chelsio/chcr_algo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypto/chelsio/chcr_algo.c
index ad8e353..e4ddb92 100644
--- a/drivers/crypto/chelsio/chcr_algo.c
+++ b/drivers/crypto/chelsio/chcr_algo.c
@@ -590,7 +590,7 @@ badkey_err:
return -EINVAL;
}

-int cxgb4_is_crypto_q_full(struct net_device *dev, unsigned int idx)
+static int cxgb4_is_crypto_q_full(struct net_device *dev, unsigned int idx)
{
int ret = 0;
struct sge_ofld_txq *q;

2016-08-24 14:05:07

by Herbert Xu

Subject: Re: [PATCH -next] chcr: Fix non static symbol warning

On Mon, Aug 22, 2016 at 04:11:18PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <[email protected]>
>
> Fixes the following sparse warning:
>
> drivers/crypto/chelsio/chcr_algo.c:593:5: warning:
> symbol 'cxgb4_is_crypto_q_full' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <[email protected]>

Please repost this to netdev as the chelsio patches were applied
in the net tree.

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2016-08-24 14:50:30

by Wei Yongjun

Subject: Re: [PATCH -next] chcr: Fix non static symbol warning

Hi Herbert,

On 08/24/2016 09:06 PM, Herbert Xu wrote:
> On Mon, Aug 22, 2016 at 04:11:18PM +0000, Wei Yongjun wrote:
>> From: Wei Yongjun <[email protected]>
>>
>> Fixes the following sparse warning:
>>
>> drivers/crypto/chelsio/chcr_algo.c:593:5: warning:
>> symbol 'cxgb4_is_crypto_q_full' was not declared. Should it be static?
>>
>> Signed-off-by: Wei Yongjun <[email protected]>
> Please repost this to netdev as the chelsio patches were applied
> in the net tree.

This file only exists in net-next, not in netdev.
http://git.kernel.org/cgit/linux/kernel/git/davem/net.git/tree/drivers/crypto/chelsio/chcr_algo.c
show not found.

Regards,
Wei Yongjun

2016-08-25 07:03:53

by Herbert Xu

Subject: Re: [PATCH -next] chcr: Fix non static symbol warning

On Wed, Aug 24, 2016 at 10:50:24PM +0800, Wei Yongjun wrote:
> Hi Herbert,
>
> On 08/24/2016 09:06 PM, Herbert Xu wrote:
> > On Mon, Aug 22, 2016 at 04:11:18PM +0000, Wei Yongjun wrote:
> >> From: Wei Yongjun <[email protected]>
> >>
> >> Fixes the following sparse warning:
> >>
> >> drivers/crypto/chelsio/chcr_algo.c:593:5: warning:
> >> symbol 'cxgb4_is_crypto_q_full' was not declared. Should it be static?
> >>
> >> Signed-off-by: Wei Yongjun <[email protected]>
> > Please repost this to netdev as the chelsio patches were applied
> > in the net tree.
>
> This file only exists in net-next, not in netdev.
> http://git.kernel.org/cgit/linux/kernel/git/davem/net.git/tree/drivers/crypto/chelsio/chcr_algo.c
> show not found.

I meant the netdev mailing list.

Cheers,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2016-08-26 14:21:08

by Wei Yongjun

Subject: [PATCH -next v2] chcr: Fix non static symbol warning

From: Wei Yongjun <[email protected]>

Fixes the following sparse warning:

drivers/crypto/chelsio/chcr_algo.c:593:5: warning:
symbol 'cxgb4_is_crypto_q_full' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <[email protected]>
---
v1 -> v2: cc netdev maillist
---
drivers/crypto/chelsio/chcr_algo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypto/chelsio/chcr_algo.c
index ad8e353..e4ddb92 100644
--- a/drivers/crypto/chelsio/chcr_algo.c
+++ b/drivers/crypto/chelsio/chcr_algo.c
@@ -590,7 +590,7 @@ badkey_err:
return -EINVAL;
}

-int cxgb4_is_crypto_q_full(struct net_device *dev, unsigned int idx)
+static int cxgb4_is_crypto_q_full(struct net_device *dev, unsigned int idx)
{
int ret = 0;
struct sge_ofld_txq *q;

2016-08-26 14:42:52

by Herbert Xu

Subject: Re: [PATCH -next v2] chcr: Fix non static symbol warning

On Fri, Aug 26, 2016 at 02:21:08PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <[email protected]>
>
> Fixes the following sparse warning:
>
> drivers/crypto/chelsio/chcr_algo.c:593:5: warning:
> symbol 'cxgb4_is_crypto_q_full' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <[email protected]>

Acked-by: Herbert Xu <[email protected]>
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt