2016-09-03 03:29:30

by Baoyou Xie

Subject: [PATCH] crypto: caam: add missing header dependencies

We get 1 warning when building kernel with W=1:
drivers/crypto/caam/ctrl.c:398:5: warning: no previous prototype for 'caam_get_era' [-Wmissing-prototypes]

In fact, this function is declared in drivers/crypto/caam/ctrl.h
and be exported, thus can be refrenced by modules, so this patch
adds missing header dependencies.

Signed-off-by: Baoyou Xie <[email protected]>
---
drivers/crypto/caam/ctrl.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c
index 0ec112e..46e72ed 100644
--- a/drivers/crypto/caam/ctrl.c
+++ b/drivers/crypto/caam/ctrl.c
@@ -14,6 +14,7 @@
#include "jr.h"
#include "desc_constr.h"
#include "error.h"
+#include "ctrl.h"

bool caam_little_end;
EXPORT_SYMBOL(caam_little_end);
--
2.7.4

2016-09-07 13:11:03

by Herbert Xu

Subject: Re: [PATCH] crypto: caam: add missing header dependencies

On Sat, Sep 03, 2016 at 11:29:30AM +0800, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/crypto/caam/ctrl.c:398:5: warning: no previous prototype for 'caam_get_era' [-Wmissing-prototypes]
>
> In fact, this function is declared in drivers/crypto/caam/ctrl.h
> and be exported, thus can be refrenced by modules, so this patch
> adds missing header dependencies.
>
> Signed-off-by: Baoyou Xie <[email protected]>

This patch has already been applied.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt