2016-09-17 16:01:29

by Wei Yongjun

Subject: [PATCH] crypto: ccp - Fix return value check in ccp_dmaengine_register()

From: Wei Yongjun <[email protected]>

Fix the retrn value check which testing the wrong variable
in ccp_dmaengine_register().

Fixes: 58ea8abf4904 ("crypto: ccp - Register the CCP as a DMA resource")
Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/crypto/ccp/ccp-dmaengine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/ccp/ccp-dmaengine.c b/drivers/crypto/ccp/ccp-dmaengine.c
index 94f77b0..32f645e 100644
--- a/drivers/crypto/ccp/ccp-dmaengine.c
+++ b/drivers/crypto/ccp/ccp-dmaengine.c
@@ -650,7 +650,7 @@ int ccp_dmaengine_register(struct ccp_device *ccp)
dma_desc_cache_name = devm_kasprintf(ccp->dev, GFP_KERNEL,
"%s-dmaengine-desc-cache",
ccp->name);
- if (!dma_cmd_cache_name)
+ if (!dma_desc_cache_name)
return -ENOMEM;
ccp->dma_desc_cache = kmem_cache_create(dma_desc_cache_name,
sizeof(struct ccp_dma_desc),

2016-09-19 18:42:03

by Gary R Hook

Subject: Re: [PATCH] crypto: ccp - Fix return value check in ccp_dmaengine_register()

On 09/17/2016 11:01 AM, Wei Yongjun wrote:
> From: Wei Yongjun <[email protected]>
>
> Fix the retrn value check which testing the wrong variable
> in ccp_dmaengine_register().
>
> Fixes: 58ea8abf4904 ("crypto: ccp - Register the CCP as a DMA resource")
> Signed-off-by: Wei Yongjun <[email protected]>
> ---
> drivers/crypto/ccp/ccp-dmaengine.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/ccp/ccp-dmaengine.c b/drivers/crypto/ccp/ccp-dmaengine.c
> index 94f77b0..32f645e 100644
> --- a/drivers/crypto/ccp/ccp-dmaengine.c
> +++ b/drivers/crypto/ccp/ccp-dmaengine.c
> @@ -650,7 +650,7 @@ int ccp_dmaengine_register(struct ccp_device *ccp)
> dma_desc_cache_name = devm_kasprintf(ccp->dev, GFP_KERNEL,
> "%s-dmaengine-desc-cache",
> ccp->name);
> - if (!dma_cmd_cache_name)
> + if (!dma_desc_cache_name)
> return -ENOMEM;
> ccp->dma_desc_cache = kmem_cache_create(dma_desc_cache_name,
> sizeof(struct ccp_dma_desc),
>

Acked-by: Gary R Hook <[email protected]>

2016-09-22 10:45:38

by Herbert Xu

Subject: Re: [PATCH] crypto: ccp - Fix return value check in ccp_dmaengine_register()

On Sat, Sep 17, 2016 at 04:01:22PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <[email protected]>
>
> Fix the retrn value check which testing the wrong variable
> in ccp_dmaengine_register().
>
> Fixes: 58ea8abf4904 ("crypto: ccp - Register the CCP as a DMA resource")
> Signed-off-by: Wei Yongjun <[email protected]>

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt