2017-01-02 13:32:30

by Salvatore Benedetto

Subject: [PATCH] crypto: kpp - clear CRYPTO_ALG_DEAD bit in prepare_alg

Make sure CRYPTO_ALG_DEAD is not set when preparing for
alg registration. This fixes qat-dh registration that occurs
when reloading qat_c62x module.

Signed-off-by: Salvatore Benedetto <[email protected]>
---
crypto/kpp.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/crypto/kpp.c b/crypto/kpp.c
index d36ce05..d1adef8e 100644
--- a/crypto/kpp.c
+++ b/crypto/kpp.c
@@ -101,6 +101,7 @@ static void kpp_prepare_alg(struct kpp_alg *alg)

base->cra_type = &crypto_kpp_type;
base->cra_flags &= ~CRYPTO_ALG_TYPE_MASK;
+ base->cra_flags &= ~CRYPTO_ALG_DEAD;
base->cra_flags |= CRYPTO_ALG_TYPE_KPP;
}

--
2.4.11

2017-01-12 15:42:02

by Herbert Xu

Subject: Re: [PATCH] crypto: kpp - clear CRYPTO_ALG_DEAD bit in prepare_alg

On Mon, Jan 02, 2017 at 01:33:41PM +0000, Salvatore Benedetto wrote:
> Make sure CRYPTO_ALG_DEAD is not set when preparing for
> alg registration. This fixes qat-dh registration that occurs
> when reloading qat_c62x module.
>
> Signed-off-by: Salvatore Benedetto <[email protected]>
> ---
> crypto/kpp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/crypto/kpp.c b/crypto/kpp.c
> index d36ce05..d1adef8e 100644
> --- a/crypto/kpp.c
> +++ b/crypto/kpp.c
> @@ -101,6 +101,7 @@ static void kpp_prepare_alg(struct kpp_alg *alg)
>
> base->cra_type = &crypto_kpp_type;
> base->cra_flags &= ~CRYPTO_ALG_TYPE_MASK;
> + base->cra_flags &= ~CRYPTO_ALG_DEAD;
> base->cra_flags |= CRYPTO_ALG_TYPE_KPP;
> }

Same comment as in

https://patchwork.kernel.org/patch/9485115/

Cheers,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt