2017-01-13 11:55:09

by Salvatore Benedetto

Subject: [PATCH] crypto: api - Clear CRYPTO_ALG_DEAD bit before registering an alg

Make sure CRYPTO_ALG_DEAD bit is cleared before proceeding with
the algorithm registration. This fixes qat-dh registration when
driver is restarted

Signed-off-by: Salvatore Benedetto <[email protected]>
---
crypto/algapi.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/crypto/algapi.c b/crypto/algapi.c
index df939b5..1fad2a6 100644
--- a/crypto/algapi.c
+++ b/crypto/algapi.c
@@ -356,6 +356,7 @@ int crypto_register_alg(struct crypto_alg *alg)
struct crypto_larval *larval;
int err;

+ alg->cra_flags &= ~CRYPTO_ALG_DEAD;
err = crypto_check_alg(alg);
if (err)
return err;
--
2.7.4

2017-01-23 14:57:51

by Herbert Xu

Subject: Re: [PATCH] crypto: api - Clear CRYPTO_ALG_DEAD bit before registering an alg

On Fri, Jan 13, 2017 at 11:54:08AM +0000, Salvatore Benedetto wrote:
> Make sure CRYPTO_ALG_DEAD bit is cleared before proceeding with
> the algorithm registration. This fixes qat-dh registration when
> driver is restarted
>
> Signed-off-by: Salvatore Benedetto <[email protected]>

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2017-01-23 17:06:36

by Salvatore Benedetto

Subject: RE: [PATCH] crypto: api - Clear CRYPTO_ALG_DEAD bit before registering an alg

Hi Herbert,

> -----Original Message-----
> From: [email protected] [mailto:linux-crypto-
> [email protected]] On Behalf Of Herbert Xu
> Sent: Monday, January 23, 2017 2:58 PM
> To: Benedetto, Salvatore <[email protected]>
> Cc: [email protected]
> Subject: Re: [PATCH] crypto: api - Clear CRYPTO_ALG_DEAD bit before
> registering an alg
>
> On Fri, Jan 13, 2017 at 11:54:08AM +0000, Salvatore Benedetto wrote:
> > Make sure CRYPTO_ALG_DEAD bit is cleared before proceeding with the
> > algorithm registration. This fixes qat-dh registration when driver is
> > restarted
> >
> > Signed-off-by: Salvatore Benedetto <[email protected]>
>
> Patch applied. Thanks.

I forgot to add CC stable to it.

This error was introduced in 4.8 and so I think it should go into stable 4.8 and 4.9.

Should I resend or can you add that?

Regards,
Salvatore

> --
> Email: Herbert Xu <[email protected]> Home Page:
> http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
> --
> To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the
> body of a message to [email protected] More majordomo info at
> http://vger.kernel.org/majordomo-info.html

2017-02-01 14:06:48

by Herbert Xu

Subject: Re: [PATCH] crypto: api - Clear CRYPTO_ALG_DEAD bit before registering an alg

On Mon, Jan 23, 2017 at 05:06:34PM +0000, Benedetto, Salvatore wrote:
>
> I forgot to add CC stable to it.
>
> This error was introduced in 4.8 and so I think it should go into stable 4.8 and 4.9.
>
> Should I resend or can you add that?

I had added it when applying the patch.

Cheers,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt