From: Suniel Mahesh <[email protected]>
This fixes the following coccinelle warning:
WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool.
Signed-off-by: Suniel Mahesh <[email protected]>
---
Note:
- Patch was tested and built(ARCH=arm) on latest
linux-next.
- No build issues reported, however it was not
tested on real hardware.
- Please discard this changeset, if this is not
helping the code look better.
---
drivers/staging/ccree/ssi_cipher.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/ssi_cipher.h b/drivers/staging/ccree/ssi_cipher.h
index c9a83df..f499962 100644
--- a/drivers/staging/ccree/ssi_cipher.h
+++ b/drivers/staging/ccree/ssi_cipher.h
@@ -75,7 +75,7 @@ struct arm_hw_key_info {
static inline bool ssi_is_hw_key(struct crypto_tfm *tfm)
{
- return 0;
+ return false;
}
#endif /* CRYPTO_TFM_REQ_HW_KEY */
--
1.9.1
On Mon, Oct 16, 2017 at 03:39:57PM +0530, [email protected] wrote:
> From: Suniel Mahesh <[email protected]>
>
> This fixes the following coccinelle warning:
> WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool.
Perhaps
Coccinelle emits WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool.
Return 'false' instead of 0.
> Signed-off-by: Suniel Mahesh <[email protected]>
> ---
> Note:
> - Patch was tested and built(ARCH=arm) on latest
> linux-next.
> - No build issues reported, however it was not
> tested on real hardware.
> - Please discard this changeset, if this is not
> helping the code look better.
> ---
> drivers/staging/ccree/ssi_cipher.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ccree/ssi_cipher.h b/drivers/staging/ccree/ssi_cipher.h
> index c9a83df..f499962 100644
> --- a/drivers/staging/ccree/ssi_cipher.h
> +++ b/drivers/staging/ccree/ssi_cipher.h
> @@ -75,7 +75,7 @@ struct arm_hw_key_info {
>
> static inline bool ssi_is_hw_key(struct crypto_tfm *tfm)
> {
> - return 0;
> + return false;
> }
Hope this helps,
Tobin.
From: Suniel Mahesh <[email protected]>
Return "false" instead of 0.
This fixes the following coccinelle warning:
WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool.
Signed-off-by: Suniel Mahesh <[email protected]>
---
Changes for v2:
- Changed the commit log to give a more accurate description
of the changeset as suggested by Toby C.Harding.
---
Note:
- Patch was built(ARCH=arm) on latest linux-next.
- No build issues reported, however it was not
tested on real hardware.
- Please discard this changeset, if this is not
helping the code look better.
---
drivers/staging/ccree/ssi_cipher.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/ssi_cipher.h b/drivers/staging/ccree/ssi_cipher.h
index c9a83df..f499962 100644
--- a/drivers/staging/ccree/ssi_cipher.h
+++ b/drivers/staging/ccree/ssi_cipher.h
@@ -75,7 +75,7 @@ struct arm_hw_key_info {
static inline bool ssi_is_hw_key(struct crypto_tfm *tfm)
{
- return 0;
+ return false;
}
#endif /* CRYPTO_TFM_REQ_HW_KEY */
--
1.9.1
On Wed, Oct 18, 2017 at 07:42:53AM +0530, [email protected] wrote:
> From: Suniel Mahesh <[email protected]>
>
> Return "false" instead of 0.
>
> This fixes the following coccinelle warning:
> WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool.
So close! The order of problem description and fix is inverted. What about
```
coccinelle emits: WARNING: return of 0/1 in function 'ssi_is_hw_key' with
return type bool.
Return "false" instead of 0.
```
Good luck,
Tobin.
From: Suniel Mahesh <[email protected]>
This fixes the following coccinelle warning:
WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool.
return "false" instead of 0.
Signed-off-by: Suniel Mahesh <[email protected]>
---
Changes for v3:
- Changed the commit log even more to give an accurate
description of the changeset as suggested by Toby C.Harding.
---
Changes for v2:
- Changed the commit log to give a more accurate description
of the changeset as suggested by Toby C.Harding.
---
Note:
- Patch was built(ARCH=arm) on latest linux-next.
- No build issues reported, however it was not
tested on real hardware.
- Please discard this changeset, if this is not
helping the code look better.
---
drivers/staging/ccree/ssi_cipher.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/ssi_cipher.h b/drivers/staging/ccree/ssi_cipher.h
index c9a83df..f499962 100644
--- a/drivers/staging/ccree/ssi_cipher.h
+++ b/drivers/staging/ccree/ssi_cipher.h
@@ -75,7 +75,7 @@ struct arm_hw_key_info {
static inline bool ssi_is_hw_key(struct crypto_tfm *tfm)
{
- return 0;
+ return false;
}
#endif /* CRYPTO_TFM_REQ_HW_KEY */
--
1.9.1
Hi Suniel,
Well done with you continued versions. I am being particularly nit picky here but since we are
striving for perfection I'm sure will humour me. If English is not your first language please
forgive me for picking you up on language subtleties.
On Wed, Oct 18, 2017 at 12:11:55PM +0530, [email protected] wrote:
> From: Suniel Mahesh <[email protected]>
>
> This fixes the following coccinelle warning:
> WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool.
This should be a description of the problem, so saying _why_ there is a problem or _what_ is wrong
with the code currently that warrants a patch. Sometimes while describing the problem you may
include descriptions of the solution especially it is not immediately obvious why your proposed
solution fixes the issue being explained. As an extra we shouldn't ever say 'This patch ...' or
'This does xyz'.
> return "false" instead of 0.
Perfect, this is in imperative mood. Spot on!
> Signed-off-by: Suniel Mahesh <[email protected]>
> ---
> Changes for v3:
> - Changed the commit log even more to give an accurate
> description of the changeset as suggested by Toby C.Harding.
My name is Tobin :)
> ---
> Changes for v2:
> - Changed the commit log to give a more accurate description
> of the changeset as suggested by Toby C.Harding.
> ---
> Note:
> - Patch was built(ARCH=arm) on latest linux-next.
> - No build issues reported, however it was not
> tested on real hardware.
> - Please discard this changeset, if this is not
> helping the code look better.
> ---
> drivers/staging/ccree/ssi_cipher.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ccree/ssi_cipher.h b/drivers/staging/ccree/ssi_cipher.h
> index c9a83df..f499962 100644
> --- a/drivers/staging/ccree/ssi_cipher.h
> +++ b/drivers/staging/ccree/ssi_cipher.h
> @@ -75,7 +75,7 @@ struct arm_hw_key_info {
>
> static inline bool ssi_is_hw_key(struct crypto_tfm *tfm)
> {
> - return 0;
> + return false;
> }
>
> #endif /* CRYPTO_TFM_REQ_HW_KEY */
> --
> 1.9.1
>
For what it's worth, Reviewed-by: Tobin C. Harding <[email protected]>
As stated I am being particularly 'nit picky', the commit log is _probably_ good enough to be
merged, I am not a maintainer though so it's not really anything to do with me. I do know however
that sometimes patches go to the bottom of Greg's list if they have comments/suggestions. I mention
this only so you learn more about the process and to help you with successfully getting you patches
merged. Keep up the work!
Good luck,
Tobin.
On Thursday 19 October 2017 02:24 AM, Tobin C. Harding wrote:
> Hi Suniel,
>
> Well done with you continued versions. I am being particularly nit picky here but since we are
> striving for perfection I'm sure will humour me. If English is not your first language please
> forgive me for picking you up on language subtleties.
Hi Tobin,
First of all, I thank you very much for the reviews, to be honest I enjoyed the process. Yes all of
us, here we are striving for perfection. I am always open to take suggestions from the community to
improve things which I am working on and there by improving myself. Yeah English is not my first
language, but all my education was done in English, no issues there.
>
> On Wed, Oct 18, 2017 at 12:11:55PM +0530, [email protected] wrote:
>> From: Suniel Mahesh <[email protected]>
>>
>> This fixes the following coccinelle warning:
>> WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool.
>
> This should be a description of the problem, so saying _why_ there is a problem or _what_ is wrong
> with the code currently that warrants a patch. Sometimes while describing the problem you may
> include descriptions of the solution especially it is not immediately obvious why your proposed
> solution fixes the issue being explained. As an extra we shouldn't ever say 'This patch ...' or
> 'This does xyz'.
>
>> return "false" instead of 0.
>
> Perfect, this is in imperative mood. Spot on!
>
>> Signed-off-by: Suniel Mahesh <[email protected]>
>> ---
>> Changes for v3:
>> - Changed the commit log even more to give an accurate
>> description of the changeset as suggested by Toby C.Harding.
>
> My name is Tobin :)
how did I blind myself, my bad, will be careful and avoid such mistakes moving forward.
>
>> ---
>> Changes for v2:
>> - Changed the commit log to give a more accurate description
>> of the changeset as suggested by Toby C.Harding.
>> ---
>> Note:
>> - Patch was built(ARCH=arm) on latest linux-next.
>> - No build issues reported, however it was not
>> tested on real hardware.
>> - Please discard this changeset, if this is not
>> helping the code look better.
>> ---
>> drivers/staging/ccree/ssi_cipher.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/ccree/ssi_cipher.h b/drivers/staging/ccree/ssi_cipher.h
>> index c9a83df..f499962 100644
>> --- a/drivers/staging/ccree/ssi_cipher.h
>> +++ b/drivers/staging/ccree/ssi_cipher.h
>> @@ -75,7 +75,7 @@ struct arm_hw_key_info {
>>
>> static inline bool ssi_is_hw_key(struct crypto_tfm *tfm)
>> {
>> - return 0;
>> + return false;
>> }
>>
>> #endif /* CRYPTO_TFM_REQ_HW_KEY */
>> --
>> 1.9.1
>>
>
> For what it's worth, Reviewed-by: Tobin C. Harding <[email protected]>
>
> As stated I am being particularly 'nit picky', the commit log is _probably_ good enough to be
> merged, I am not a maintainer though so it's not really anything to do with me. I do know however
> that sometimes patches go to the bottom of Greg's list if they have comments/suggestions. I mention
> this only so you learn more about the process and to help you with successfully getting you patches
> merged. Keep up the work!
Thanks once again Tobin, I love feedback and that's how we can make this world a better workplace.
Suniel
>
> Good luck,
> Tobin.
>