2020-12-01 06:53:57

by Yejune Deng

Subject: [PATCH] crypto: hisilicon/trng replace atomic_add_return()

a set of atomic_inc_return() looks more neater

Signed-off-by: Yejune Deng <[email protected]>
---
drivers/crypto/hisilicon/trng/trng.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/crypto/hisilicon/trng/trng.c b/drivers/crypto/hisilicon/trng/trng.c
index a5033cf..2971268 100644
--- a/drivers/crypto/hisilicon/trng/trng.c
+++ b/drivers/crypto/hisilicon/trng/trng.c
@@ -267,12 +267,12 @@ static int hisi_trng_probe(struct platform_device *pdev)
}

hisi_trng_add_to_list(trng);
- if (atomic_add_return(1, &trng_active_devs) == 1) {
+ if (atomic_inc_return(&trng_active_devs) == 1) {
ret = crypto_register_rng(&hisi_trng_alg);
if (ret) {
dev_err(&pdev->dev,
"failed to register crypto(%d)\n", ret);
- atomic_sub_return(1, &trng_active_devs);
+ atomic_dec_return(&trng_active_devs);
goto err_remove_from_list;
}
}
@@ -289,7 +289,7 @@ static int hisi_trng_probe(struct platform_device *pdev)
return ret;

err_crypto_unregister:
- if (atomic_sub_return(1, &trng_active_devs) == 0)
+ if (atomic_dec_return(&trng_active_devs) == 0)
crypto_unregister_rng(&hisi_trng_alg);

err_remove_from_list:
@@ -305,7 +305,7 @@ static int hisi_trng_remove(struct platform_device *pdev)
while (hisi_trng_del_from_list(trng))
;

- if (atomic_sub_return(1, &trng_active_devs) == 0)
+ if (atomic_dec_return(&trng_active_devs) == 0)
crypto_unregister_rng(&hisi_trng_alg);

return 0;
--
1.9.1

2020-12-11 13:32:10

by Herbert Xu

Subject: Re: [PATCH] crypto: hisilicon/trng replace atomic_add_return()

On Tue, Dec 01, 2020 at 02:50:18PM +0800, Yejune Deng wrote:
> a set of atomic_inc_return() looks more neater
>
> Signed-off-by: Yejune Deng <[email protected]>
> ---
> drivers/crypto/hisilicon/trng/trng.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)

All applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt