2021-02-04 07:26:57

by Jiapeng Chong

Subject: [PATCH] crypto: picoxcell - convert sysfs sprintf/snprintf family to sysfs_emit

Fix the following coccicheck warning:

./drivers/crypto/picoxcell_crypto.c:1201:8-16: WARNING: use scnprintf
or sprintf.

Reported-by: Abaci Robot<[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/crypto/picoxcell_crypto.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/picoxcell_crypto.c b/drivers/crypto/picoxcell_crypto.c
index 84f9c16..d7a7def 100644
--- a/drivers/crypto/picoxcell_crypto.c
+++ b/drivers/crypto/picoxcell_crypto.c
@@ -1198,7 +1198,7 @@ static ssize_t spacc_stat_irq_thresh_show(struct device *dev,
{
struct spacc_engine *engine = spacc_dev_to_engine(dev);

- return snprintf(buf, PAGE_SIZE, "%u\n", engine->stat_irq_thresh);
+ return sysfs_emit(buf, "%u\n", engine->stat_irq_thresh);
}

static ssize_t spacc_stat_irq_thresh_store(struct device *dev,
--
1.8.3.1

2021-02-10 08:35:37

by Herbert Xu

Subject: Re: [PATCH] crypto: picoxcell - convert sysfs sprintf/snprintf family to sysfs_emit

On Thu, Feb 04, 2021 at 03:24:13PM +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warning:
>
> ./drivers/crypto/picoxcell_crypto.c:1201:8-16: WARNING: use scnprintf
> or sprintf.
>
> Reported-by: Abaci Robot<[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> drivers/crypto/picoxcell_crypto.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

This driver no longer exists.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt