2021-02-07 02:41:02

by Tian Tao

Subject: [PATCH] hw_random: timeriomem_rng: Use device-managed registration API

Use devm_hwrng_register to get rid of manual unregistration.

Signed-off-by: Tian Tao <[email protected]>
---
drivers/char/hw_random/timeriomem-rng.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/char/hw_random/timeriomem-rng.c b/drivers/char/hw_random/timeriomem-rng.c
index e262445..9c237a0 100644
--- a/drivers/char/hw_random/timeriomem-rng.c
+++ b/drivers/char/hw_random/timeriomem-rng.c
@@ -169,7 +169,7 @@ static int timeriomem_rng_probe(struct platform_device *pdev)
priv->present = 1;
complete(&priv->completion);

- err = hwrng_register(&priv->rng_ops);
+ err = devm_hwrng_register(&pdev->dev, &priv->rng_ops);
if (err) {
dev_err(&pdev->dev, "problem registering\n");
return err;
@@ -185,7 +185,6 @@ static int timeriomem_rng_remove(struct platform_device *pdev)
{
struct timeriomem_rng_private *priv = platform_get_drvdata(pdev);

- hwrng_unregister(&priv->rng_ops);
hrtimer_cancel(&priv->timer);

return 0;
--
2.7.4

2021-02-10 08:42:10

by Herbert Xu

Subject: Re: [PATCH] hw_random: timeriomem_rng: Use device-managed registration API

On Sun, Feb 07, 2021 at 10:39:05AM +0800, Tian Tao wrote:
> Use devm_hwrng_register to get rid of manual unregistration.
>
> Signed-off-by: Tian Tao <[email protected]>
> ---
> drivers/char/hw_random/timeriomem-rng.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt