2021-03-16 15:48:46

by Jay Fang

Subject: [PATCH] hwrng: core - convert sysfs sprintf/snprintf family to sysfs_emit

From: Zihao Tang <[email protected]>

Fix the following coccicheck warning:

drivers/char/hw_random/core.c:399:8-16: WARNING: use scnprintf or sprintf.

Signed-off-by: Zihao Tang <[email protected]>
Signed-off-by: Jay Fang <[email protected]>
---
drivers/char/hw_random/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
index 8c1c47d..adb3c2b 100644
--- a/drivers/char/hw_random/core.c
+++ b/drivers/char/hw_random/core.c
@@ -396,7 +396,7 @@ static ssize_t hwrng_attr_selected_show(struct device *dev,
struct device_attribute *attr,
char *buf)
{
- return snprintf(buf, PAGE_SIZE, "%d\n", cur_rng_set_by_user);
+ return sysfs_emit(buf, "%d\n", cur_rng_set_by_user);
}

static DEVICE_ATTR(rng_current, S_IRUGO | S_IWUSR,
--
2.7.4

2021-03-26 09:33:45

by Herbert Xu

Subject: Re: [PATCH] hwrng: core - convert sysfs sprintf/snprintf family to sysfs_emit

On Tue, Mar 16, 2021 at 08:34:12PM +0800, Jay Fang wrote:
> From: Zihao Tang <[email protected]>
>
> Fix the following coccicheck warning:
>
> drivers/char/hw_random/core.c:399:8-16: WARNING: use scnprintf or sprintf.
>
> Signed-off-by: Zihao Tang <[email protected]>
> Signed-off-by: Jay Fang <[email protected]>
> ---
> drivers/char/hw_random/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt