2021-04-10 09:54:02

by Hui Tang

Subject: [PATCH v3] crypto: hisilicon/hpre - delete redundant log and return in advance

'hpre_cfg_by_dsm' has checked and printed error path internally. It is not
necessary to do it here, so remove it.

It should return error immediately when return value of 'hpre_cfg_by_dsm'
is non-zero, and no need to execute the remaining sentences.

Signed-off-by: Hui Tang <[email protected]>

---
v1 -> v2:
- Return immediately when return value of 'hpre_cfg_by_dsm' is
non-zero.
v2 -> v3:
- Add description for return if function fails.
---
drivers/crypto/hisilicon/hpre/hpre_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/hisilicon/hpre/hpre_main.c b/drivers/crypto/hisilicon/hpre/hpre_main.c
index a8c7921..264684a 100644
--- a/drivers/crypto/hisilicon/hpre/hpre_main.c
+++ b/drivers/crypto/hisilicon/hpre/hpre_main.c
@@ -384,7 +384,7 @@ static int hpre_set_user_domain_and_cache(struct hisi_qm *qm)
if (qm->ver == QM_HW_V2) {
ret = hpre_cfg_by_dsm(qm);
if (ret)
- dev_err(dev, "acpi_evaluate_dsm err.\n");
+ return ret;

disable_flr_of_bme(qm);
}
--
2.8.1

2021-04-16 11:44:51

by Herbert Xu

Subject: Re: [PATCH v3] crypto: hisilicon/hpre - delete redundant log and return in advance

On Sat, Apr 10, 2021 at 05:50:32PM +0800, Hui Tang wrote:
> 'hpre_cfg_by_dsm' has checked and printed error path internally. It is not
> necessary to do it here, so remove it.
>
> It should return error immediately when return value of 'hpre_cfg_by_dsm'
> is non-zero, and no need to execute the remaining sentences.
>
> Signed-off-by: Hui Tang <[email protected]>
>
> ---
> v1 -> v2:
> - Return immediately when return value of 'hpre_cfg_by_dsm' is
> non-zero.
> v2 -> v3:
> - Add description for return if function fails.
> ---
> drivers/crypto/hisilicon/hpre/hpre_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt