2021-05-20 07:59:04

by Zhangshaokun

Subject: [PATCH] hwrng: core - remove redundant initialization of variable err

'err' will be assigned later and cleanup the redundant initialization.

Cc: PrasannaKumar Muralidharan <[email protected]>
Cc: Herbert Xu <[email protected]>
Signed-off-by: Shaokun Zhang <[email protected]>
---
drivers/char/hw_random/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
index adb3c2bd7783..322e3d0ea98c 100644
--- a/drivers/char/hw_random/core.c
+++ b/drivers/char/hw_random/core.c
@@ -323,7 +323,7 @@ static ssize_t hwrng_attr_current_store(struct device *dev,
struct device_attribute *attr,
const char *buf, size_t len)
{
- int err = -ENODEV;
+ int err;
struct hwrng *rng, *old_rng, *new_rng;

err = mutex_lock_interruptible(&rng_mutex);
--
2.7.4

2021-05-28 07:44:24

by Herbert Xu

Subject: Re: [PATCH] hwrng: core - remove redundant initialization of variable err

On Thu, May 20, 2021 at 03:56:11PM +0800, Shaokun Zhang wrote:
> 'err' will be assigned later and cleanup the redundant initialization.
>
> Cc: PrasannaKumar Muralidharan <[email protected]>
> Cc: Herbert Xu <[email protected]>
> Signed-off-by: Shaokun Zhang <[email protected]>
> ---
> drivers/char/hw_random/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt