2021-08-13 07:48:38

by yekai (A)

[permalink] [raw]
Subject: [PATCH v4 0/2] crypto: hisilicon - some misc bugfix for SEC engine

some misc bugfix for SEC engine.

changes v1->v2:
delete the "ifdefs", use the IS_ENABLED.
changes v2->v3:
fix merge conflict
changes v3->v4:
fix build error.

Kai Ye (2):
crypto: hisilicon/sec - fix the abnormal exiting process
crypto: hisilicon/sec - modify the hardware endian configuration

drivers/crypto/hisilicon/sec2/sec.h | 5 -----
drivers/crypto/hisilicon/sec2/sec_main.c | 34 +++++++++++---------------------
2 files changed, 11 insertions(+), 28 deletions(-)

--
2.7.4


2021-08-13 07:50:35

by yekai (A)

[permalink] [raw]
Subject: [PATCH v4 1/2] crypto: hisilicon/sec - fix the abnormal exiting process

Because the algs registration process has added a judgment.
So need to add the judgment for the abnormal exiting process.

Signed-off-by: Kai Ye <[email protected]>
---
drivers/crypto/hisilicon/sec2/sec_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/hisilicon/sec2/sec_main.c b/drivers/crypto/hisilicon/sec2/sec_main.c
index db4dbcf..45a1ddd 100644
--- a/drivers/crypto/hisilicon/sec2/sec_main.c
+++ b/drivers/crypto/hisilicon/sec2/sec_main.c
@@ -1020,7 +1020,8 @@ static int sec_probe(struct pci_dev *pdev, const struct pci_device_id *id)
return 0;

err_alg_unregister:
- hisi_qm_alg_unregister(qm, &sec_devices);
+ if (qm->qp_num >= ctx_q_num)
+ hisi_qm_alg_unregister(qm, &sec_devices);
err_qm_stop:
sec_debugfs_exit(qm);
hisi_qm_stop(qm, QM_NORMAL);
--
2.7.4

2021-08-21 07:50:36

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH v4 0/2] crypto: hisilicon - some misc bugfix for SEC engine

On Fri, Aug 13, 2021 at 03:41:00PM +0800, Kai Ye wrote:
> some misc bugfix for SEC engine.
>
> changes v1->v2:
> delete the "ifdefs", use the IS_ENABLED.
> changes v2->v3:
> fix merge conflict
> changes v3->v4:
> fix build error.
>
> Kai Ye (2):
> crypto: hisilicon/sec - fix the abnormal exiting process
> crypto: hisilicon/sec - modify the hardware endian configuration
>
> drivers/crypto/hisilicon/sec2/sec.h | 5 -----
> drivers/crypto/hisilicon/sec2/sec_main.c | 34 +++++++++++---------------------
> 2 files changed, 11 insertions(+), 28 deletions(-)

All applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt