2016-04-29 14:48:20

by Tudor-Dan Ambarus

Subject: [PATCH] lib: asn1_decoder - add MODULE_LICENSE("GPL")

A kernel taint results when loading the rsa_generic module:

root@(none):~# modprobe rsa_generic
asn1_decoder: module license 'unspecified' taints kernel.
Disabling lock debugging due to kernel taint

"Tainting" of the kernel is (usually) a way of indicating that
a proprietary module has been inserted, which is not the case here.

Signed-off-by: Tudor Ambarus <[email protected]>
---
lib/asn1_decoder.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/lib/asn1_decoder.c b/lib/asn1_decoder.c
index 2b3f46c..b1ffcab 100644
--- a/lib/asn1_decoder.c
+++ b/lib/asn1_decoder.c
@@ -12,6 +12,7 @@
#include <linux/export.h>
#include <linux/kernel.h>
#include <linux/errno.h>
+#include <linux/module.h>
#include <linux/asn1_decoder.h>
#include <linux/asn1_ber_bytecode.h>

@@ -504,3 +505,5 @@ error:
return -EBADMSG;
}
EXPORT_SYMBOL_GPL(asn1_ber_decoder);
+
+MODULE_LICENSE("GPL");
--
1.8.3.1

2016-05-11 13:53:57

by David Howells

Subject: Re: [PATCH] lib: asn1_decoder - add MODULE_LICENSE("GPL")

Tudor Ambarus <[email protected]> wrote:

> A kernel taint results when loading the rsa_generic module:
>
> root@(none):~# modprobe rsa_generic
> asn1_decoder: module license 'unspecified' taints kernel.
> Disabling lock debugging due to kernel taint
>
> "Tainting" of the kernel is (usually) a way of indicating that
> a proprietary module has been inserted, which is not the case here.
>
> Signed-off-by: Tudor Ambarus <[email protected]>

Applied.