2011-02-25 18:00:59

by Atul Sowani

Subject: [PATCH 2.6.37.2 1/1] crypto: Uninitialized variable fix.

Array inter[4] was uninitialized in anubis_crypt() and was causing
compiler warning. Added the array initialization.

Signed-off-by: Atul Sowani <[email protected]>
---

diff a/crypto/anubis.c b/crypto/anubis.c
--- a/crypto/anubis.c 2011-02-25 04:39:00.000000000 +0530
+++ b/crypto/anubis.c 2011-02-25 23:07:12.000000000 +0530
@@ -578,7 +578,7 @@ static void anubis_crypt(u32 roundKey[AN
__be32 *dst = (__be32 *)ciphertext;
int i, r;
u32 state[4];
- u32 inter[4];
+ u32 inter[4] = { 0, 0, 0, 0 };

/*
* map plaintext block to cipher state (mu)

2011-02-25 18:10:18

by Greg KH

Subject: Re: [PATCH 2.6.37.2 1/1] crypto: Uninitialized variable fix.

On Fri, Feb 25, 2011 at 11:28:28PM +0530, Atul Sowani wrote:
> Array inter[4] was uninitialized in anubis_crypt() and was causing
> compiler warning. Added the array initialization.
>
> Signed-off-by: Atul Sowani <[email protected]>
> ---
>
> diff a/crypto/anubis.c b/crypto/anubis.c
> --- a/crypto/anubis.c 2011-02-25 04:39:00.000000000 +0530
> +++ b/crypto/anubis.c 2011-02-25 23:07:12.000000000 +0530
> @@ -578,7 +578,7 @@ static void anubis_crypt(u32 roundKey[AN
> __be32 *dst = (__be32 *)ciphertext;
> int i, r;
> u32 state[4];
> - u32 inter[4];
> + u32 inter[4] = { 0, 0, 0, 0 };

That's nice, it looks like a bug in the compiler, preinitializing this
variable doesn't fix any real bug.

sorry,

greg k-h