2013-01-19 11:31:41

by Jussi Kivilinna

Subject: [PATCH] crypto: testmgr - add test vector for fcrypt

fcrypt is used only as pcbc(fcrypt), but testmgr does not know this.
Use the zero key, zero plaintext pcbc(fcrypt) test vector for
testing plain 'fcrypt' to hide "no test for fcrypt" warnings.

Signed-off-by: Jussi Kivilinna <[email protected]>
---
crypto/testmgr.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)

diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index edf4a08..efd8b20 100644
--- a/crypto/testmgr.c
+++ b/crypto/testmgr.c
@@ -2269,6 +2269,21 @@ static const struct alg_test_desc alg_test_descs[] = {
}
}
}, {
+ .alg = "ecb(fcrypt)",
+ .test = alg_test_skcipher,
+ .suite = {
+ .cipher = {
+ .enc = {
+ .vecs = fcrypt_pcbc_enc_tv_template,
+ .count = 1
+ },
+ .dec = {
+ .vecs = fcrypt_pcbc_dec_tv_template,
+ .count = 1
+ }
+ }
+ }
+ }, {
.alg = "ecb(khazad)",
.test = alg_test_skcipher,
.suite = {

2013-01-19 15:39:13

by David Miller

Subject: Re: [PATCH] crypto: testmgr - add test vector for fcrypt

From: Jussi Kivilinna <[email protected]>
Date: Sat, 19 Jan 2013 13:31:36 +0200

> fcrypt is used only as pcbc(fcrypt), but testmgr does not know this.
> Use the zero key, zero plaintext pcbc(fcrypt) test vector for
> testing plain 'fcrypt' to hide "no test for fcrypt" warnings.
>
> Signed-off-by: Jussi Kivilinna <[email protected]>

Acked-by: David S. Miller <[email protected]>

2013-01-20 00:13:42

by Herbert Xu

Subject: Re: [PATCH] crypto: testmgr - add test vector for fcrypt

On Sat, Jan 19, 2013 at 10:39:08AM -0500, David Miller wrote:
> From: Jussi Kivilinna <[email protected]>
> Date: Sat, 19 Jan 2013 13:31:36 +0200
>
> > fcrypt is used only as pcbc(fcrypt), but testmgr does not know this.
> > Use the zero key, zero plaintext pcbc(fcrypt) test vector for
> > testing plain 'fcrypt' to hide "no test for fcrypt" warnings.
> >
> > Signed-off-by: Jussi Kivilinna <[email protected]>
>
> Acked-by: David S. Miller <[email protected]>

Applied. Thanks!
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt