2013-01-26 07:49:55

by Dan Carpenter

Subject: [patch] padata: test correct variable in ->store function

It's testing for ->show but calling ->store().

Signed-off-by: Dan Carpenter <[email protected]>
---
Static analysis. I don't know if it affects real life.

diff --git a/kernel/padata.c b/kernel/padata.c
index 072f4ee..7ac61c1 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -1013,7 +1013,7 @@ static ssize_t padata_sysfs_store(struct kobject *kobj, struct attribute *attr,

pinst = kobj2pinst(kobj);
pentry = attr2pentry(attr);
- if (pentry->show)
+ if (pentry->store)
ret = pentry->store(pinst, attr, buf, count);

return ret;

2013-01-28 09:48:41

by Steffen Klassert

Subject: Re: [patch] padata: test correct variable in ->store function

On Sat, Jan 26, 2013 at 10:49:46AM +0300, Dan Carpenter wrote:
> It's testing for ->show but calling ->store().
>
> Signed-off-by: Dan Carpenter <[email protected]>

Looks like a copy and paste error.

Acked-by: Steffen Klassert <[email protected]>

Herbert, are you going to take this one?

Thanks!