2013-05-06 03:48:42

by Jingoo Han

Subject: [PATCH 1/2] crypto: mv_cesa: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by: Jingoo Han <[email protected]>
---
drivers/crypto/mv_cesa.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/crypto/mv_cesa.c b/drivers/crypto/mv_cesa.c
index ce6290e..3374a3e 100644
--- a/drivers/crypto/mv_cesa.c
+++ b/drivers/crypto/mv_cesa.c
@@ -1146,7 +1146,6 @@ err_unmap_reg:
err:
kfree(cp);
cpg = NULL;
- platform_set_drvdata(pdev, NULL);
return ret;
}

--
1.7.2.5

2013-05-06 05:12:16

by Andrew Lunn

Subject: Re: [PATCH 1/2] crypto: mv_cesa: remove unnecessary platform_set_drvdata()

On Mon, May 06, 2013 at 12:48:41PM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <[email protected]>
> ---
> drivers/crypto/mv_cesa.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/crypto/mv_cesa.c b/drivers/crypto/mv_cesa.c
> index ce6290e..3374a3e 100644
> --- a/drivers/crypto/mv_cesa.c
> +++ b/drivers/crypto/mv_cesa.c
> @@ -1146,7 +1146,6 @@ err_unmap_reg:
> err:
> kfree(cp);
> cpg = NULL;
> - platform_set_drvdata(pdev, NULL);
> return ret;
> }
>

Acked-by: Andrew Lunn <[email protected]>