2014-06-09 15:19:41

by Dan Carpenter

[permalink] [raw]
Subject: [patch] crypto: caam - remove duplicate FIFOST_CONT_MASK define

The FIFOST_CONT_MASK define is cut and pasted twice so we can delete the
second instance.

Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/drivers/crypto/caam/desc.h b/drivers/crypto/caam/desc.h
index 7e4500f..d397ff9 100644
--- a/drivers/crypto/caam/desc.h
+++ b/drivers/crypto/caam/desc.h
@@ -321,7 +321,6 @@ struct sec4_sg_entry {
/* Continue - Not the last FIFO store to come */
#define FIFOST_CONT_SHIFT 23
#define FIFOST_CONT_MASK (1 << FIFOST_CONT_SHIFT)
-#define FIFOST_CONT_MASK (1 << FIFOST_CONT_SHIFT)

/*
* Extended Length - use 32-bit extended length that


2014-06-12 23:23:36

by Kim Phillips

[permalink] [raw]
Subject: Re: [patch] crypto: caam - remove duplicate FIFOST_CONT_MASK define

On Mon, 9 Jun 2014 18:19:41 +0300
Dan Carpenter <[email protected]> wrote:

> The FIFOST_CONT_MASK define is cut and pasted twice so we can delete the
> second instance.
>
> Signed-off-by: Dan Carpenter <[email protected]>

Acked-by: Kim Phillips <[email protected]>

Thanks,

Kim

2014-06-14 03:48:19

by Marek Vasut

[permalink] [raw]
Subject: Re: [patch] crypto: caam - remove duplicate FIFOST_CONT_MASK define

On Monday, June 09, 2014 at 05:19:41 PM, Dan Carpenter wrote:
> The FIFOST_CONT_MASK define is cut and pasted twice so we can delete the
> second instance.
>
> Signed-off-by: Dan Carpenter <[email protected]>
>
> diff --git a/drivers/crypto/caam/desc.h b/drivers/crypto/caam/desc.h
> index 7e4500f..d397ff9 100644
> --- a/drivers/crypto/caam/desc.h
> +++ b/drivers/crypto/caam/desc.h
> @@ -321,7 +321,6 @@ struct sec4_sg_entry {
> /* Continue - Not the last FIFO store to come */
> #define FIFOST_CONT_SHIFT 23
> #define FIFOST_CONT_MASK (1 << FIFOST_CONT_SHIFT)
> -#define FIFOST_CONT_MASK (1 << FIFOST_CONT_SHIFT)
>
> /*
> * Extended Length - use 32-bit extended length that

Sigh, I'm surprised the compiler didn't choke about this.

Acked-by: Marek Vasut <[email protected]>

Best regards,
Marek Vasut

2014-06-20 18:42:53

by Herbert Xu

[permalink] [raw]
Subject: Re: [patch] crypto: caam - remove duplicate FIFOST_CONT_MASK define

On Thu, Jun 12, 2014 at 06:18:12PM -0500, Kim Phillips wrote:
> On Mon, 9 Jun 2014 18:19:41 +0300
> Dan Carpenter <[email protected]> wrote:
>
> > The FIFOST_CONT_MASK define is cut and pasted twice so we can delete the
> > second instance.
> >
> > Signed-off-by: Dan Carpenter <[email protected]>
>
> Acked-by: Kim Phillips <[email protected]>

Patch applied.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt