2014-10-15 18:33:23

by Allan, Bruce W

Subject: [cryptodev PATCH] qat: cleanup unnecessary break checkpatch warning

WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return
#472: FILE: drivers/crypto/qat/qat_common/qat_algs.c:472:
+ goto bad_key;
+ break;

Signed-off-by: Bruce Allan <[email protected]>
---

drivers/crypto/qat/qat_common/qat_algs.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/crypto/qat/qat_common/qat_algs.c b/drivers/crypto/qat/qat_common/qat_algs.c
index 3e26fa2..e03afe9 100644
--- a/drivers/crypto/qat/qat_common/qat_algs.c
+++ b/drivers/crypto/qat/qat_common/qat_algs.c
@@ -469,7 +469,6 @@ static int qat_alg_init_sessions(struct qat_alg_session_ctx *ctx,
break;
default:
goto bad_key;
- break;
}

if (qat_alg_init_enc_session(ctx, alg, &keys))

2014-10-24 14:55:09

by Herbert Xu

Subject: Re: [cryptodev PATCH] qat: cleanup unnecessary break checkpatch warning

On Wed, Oct 15, 2014 at 11:33:27AM -0700, Bruce Allan wrote:
> WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return
> #472: FILE: drivers/crypto/qat/qat_common/qat_algs.c:472:
> + goto bad_key;
> + break;
>
> Signed-off-by: Bruce Allan <[email protected]>

Applied.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt