2015-01-16 07:09:27

by Herbert Xu

[permalink] [raw]
Subject: crypto: cts - Remove bogus use of seqiv

The seqiv generator is completely inappropriate for cts as it's
designed for IPsec algorithms. Since cts users do not actually
use the IV generator we can just fall back to the default.

Signed-off-by: Herbert Xu <[email protected]>

diff --git a/crypto/cts.c b/crypto/cts.c
index bd94058..6a8089c 100644
--- a/crypto/cts.c
+++ b/crypto/cts.c
@@ -307,8 +307,6 @@ static struct crypto_instance *crypto_cts_alloc(struct rtattr **tb)
inst->alg.cra_blkcipher.min_keysize = alg->cra_blkcipher.min_keysize;
inst->alg.cra_blkcipher.max_keysize = alg->cra_blkcipher.max_keysize;

- inst->alg.cra_blkcipher.geniv = "seqiv";
-
inst->alg.cra_ctxsize = sizeof(struct crypto_cts_ctx);

inst->alg.cra_init = crypto_cts_init_tfm;
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


2015-01-16 16:53:19

by Maciej Żenczykowski

[permalink] [raw]
Subject: Re: crypto: cts - Remove bogus use of seqiv

On Thu, Jan 15, 2015 at 11:09 PM, Herbert Xu
<[email protected]> wrote:
> The seqiv generator is completely inappropriate for cts as it's
> designed for IPsec algorithms. Since cts users do not actually
> use the IV generator we can just fall back to the default.
>
> Signed-off-by: Herbert Xu <[email protected]>
>
> diff --git a/crypto/cts.c b/crypto/cts.c
> index bd94058..6a8089c 100644
> --- a/crypto/cts.c
> +++ b/crypto/cts.c
> @@ -307,8 +307,6 @@ static struct crypto_instance *crypto_cts_alloc(struct rtattr **tb)
> inst->alg.cra_blkcipher.min_keysize = alg->cra_blkcipher.min_keysize;
> inst->alg.cra_blkcipher.max_keysize = alg->cra_blkcipher.max_keysize;
>
> - inst->alg.cra_blkcipher.geniv = "seqiv";
> -
> inst->alg.cra_ctxsize = sizeof(struct crypto_cts_ctx);
>
> inst->alg.cra_init = crypto_cts_init_tfm;
> --
> Email: Herbert Xu <[email protected]>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Acked-by: Maciej Żenczykowski <[email protected]>