2015-10-14 15:00:04

by Fengguang Wu

[permalink] [raw]

Subject: [cryptodev:master 62/67] drivers/char/hw_random/stm32-rng.c:163:51: error: 'pdev' undeclared

---

tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
head: 62f57d05e287e950c6e1246b1dba08e12985195a
commit: c6a97c42e399ad0d639f616e58e13f0b4ae87626 [62/67] hwrng: stm32 - add support for STM32 HW RNG
config: i386-allmodconfig (attached as .config)
reproduce:
git checkout c6a97c42e399ad0d639f616e58e13f0b4ae87626
# save the attached .config to linux build tree
make ARCH=i386

All errors (new ones prefixed by >>):

drivers/char/hw_random/stm32-rng.c: In function 'stm32_rng_runtime_suspend':
>> drivers/char/hw_random/stm32-rng.c:163:51: error: 'pdev' undeclared (first use in this function)
struct stm32_rng_private *priv = dev_get_drvdata(pdev);
^
drivers/char/hw_random/stm32-rng.c:163:51: note: each undeclared identifier is reported only once for each function it appears in
drivers/char/hw_random/stm32-rng.c: In function 'stm32_rng_runtime_resume':
drivers/char/hw_random/stm32-rng.c:172:51: error: 'pdev' undeclared (first use in this function)
struct stm32_rng_private *priv = dev_get_drvdata(pdev);
^

vim +/pdev +163 drivers/char/hw_random/stm32-rng.c

157 return devm_hwrng_register(dev, &priv->rng);
158 }
159
160 #ifdef CONFIG_PM
161 static int stm32_rng_runtime_suspend(struct device *dev)
162 {
> 163 struct stm32_rng_private *priv = dev_get_drvdata(pdev);
164
165 stm32_rng_cleanup(&priv->rng);
166

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

---

Attachments:

(No filename) (1.67 kB)
.config.gz (50.30 kB)
Download all attachments

2015-10-14 15:15:04

by Daniel Thompson

[permalink] [raw]

Subject: Re: [cryptodev:master 62/67] drivers/char/hw_random/stm32-rng.c:163:51: error: 'pdev' undeclared

---

On 14/10/15 15:59, kbuild test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
> head: 62f57d05e287e950c6e1246b1dba08e12985195a
> commit: c6a97c42e399ad0d639f616e58e13f0b4ae87626 [62/67] hwrng: stm32 - add support for STM32 HW RNG
> config: i386-allmodconfig (attached as .config)
> reproduce:
> git checkout c6a97c42e399ad0d639f616e58e13f0b4ae87626
> # save the attached .config to linux build tree
> make ARCH=i386
>
> All errors (new ones prefixed by >>):
>
> drivers/char/hw_random/stm32-rng.c: In function 'stm32_rng_runtime_suspend':
>>> drivers/char/hw_random/stm32-rng.c:163:51: error: 'pdev' undeclared (first use in this function)
> struct stm32_rng_private *priv = dev_get_drvdata(pdev);
> ^
> drivers/char/hw_random/stm32-rng.c:163:51: note: each undeclared identifier is reported only once for each function it appears in
> drivers/char/hw_random/stm32-rng.c: In function 'stm32_rng_runtime_resume':
> drivers/char/hw_random/stm32-rng.c:172:51: error: 'pdev' undeclared (first use in this function)
> struct stm32_rng_private *priv = dev_get_drvdata(pdev);
> ^
>
> vim +/pdev +163 drivers/char/hw_random/stm32-rng.c
>
> 157 return devm_hwrng_register(dev, &priv->rng);
> 158 }
> 159
> 160 #ifdef CONFIG_PM
> 161 static int stm32_rng_runtime_suspend(struct device *dev)
> 162 {
> > 163 struct stm32_rng_private *priv = dev_get_drvdata(pdev);
> 164
> 165 stm32_rng_cleanup(&priv->rng);
> 166

Oops...

That is a serious oversight on my side. Unlike all my other kernel work
I test the STM32 stuff with a buildroot wrapper. I checked that I had
CONFIG_PM enabled (for good compile coverage) but it looks like I forgot
the "linux-rebuild" when I made final tweaks to the patchset.

I will fix immediately.


Daniel.