2016-01-06 09:56:36

by Yang Pingchao

Subject: [PATCH] crypto: qat - remove redundant function call

adf_dev_restore(accel_dev) was called in adf_dev_shutdown,no
need to call it in adf_device_reset_worker after adf_dev_shutdown
was called.

Signed-off-by: Yang Pingchao <[email protected]>
---
drivers/crypto/qat/qat_common/adf_aer.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/crypto/qat/qat_common/adf_aer.c b/drivers/crypto/qat/qat_common/adf_aer.c
index e78a1d7..b40d9c8 100644
--- a/drivers/crypto/qat/qat_common/adf_aer.c
+++ b/drivers/crypto/qat/qat_common/adf_aer.c
@@ -121,7 +121,6 @@ static void adf_device_reset_worker(struct work_struct *work)
adf_dev_restarting_notify(accel_dev);
adf_dev_stop(accel_dev);
adf_dev_shutdown(accel_dev);
- adf_dev_restore(accel_dev);
if (adf_dev_init(accel_dev) || adf_dev_start(accel_dev)) {
/* The device hanged and we can't restart it so stop here */
dev_err(&GET_DEV(accel_dev), "Restart device failed\n");
--
2.6.4

2016-01-25 14:47:42

by Herbert Xu

Subject: Re: [PATCH] crypto: qat - remove redundant function call

On Wed, Jan 06, 2016 at 05:56:20PM +0800, Yang Pingchao wrote:
> adf_dev_restore(accel_dev) was called in adf_dev_shutdown,no
> need to call it in adf_device_reset_worker after adf_dev_shutdown
> was called.
>
> Signed-off-by: Yang Pingchao <[email protected]>

Applied.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt