2016-02-09 11:21:51

by Salvatore Benedetto

Subject: [PATCH] crypto: qat - Set ctx->e to NULL in qat_rsa_exit_tfm

Signed-off-by: Salvatore Benedetto <[email protected]>
---
drivers/crypto/qat/qat_common/qat_asym_algs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/qat/qat_common/qat_asym_algs.c b/drivers/crypto/qat/qat_common/qat_asym_algs.c
index 51c594f..54e386e 100644
--- a/drivers/crypto/qat/qat_common/qat_asym_algs.c
+++ b/drivers/crypto/qat/qat_common/qat_asym_algs.c
@@ -709,7 +709,7 @@ static void qat_rsa_exit_tfm(struct crypto_akcipher *tfm)
}
qat_crypto_put_instance(ctx->inst);
ctx->n = NULL;
- ctx->d = NULL;
+ ctx->e = NULL;
ctx->d = NULL;
}

--
1.9.1

2016-02-09 11:24:31

by Herbert Xu

Subject: Re: [PATCH] crypto: qat - Set ctx->e to NULL in qat_rsa_exit_tfm

On Tue, Feb 09, 2016 at 11:21:35AM +0000, Salvatore Benedetto wrote:
> Signed-off-by: Salvatore Benedetto <[email protected]>

We already use kzfree on the tfm, so we can get rid of all these
manual zeroing.

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt