2016-05-11 19:29:25

by Muhammad Falak R Wani

Subject: [PATCH] crypto: qat: remove unused vairable.

Remove the unused variable ret, and return 0 explicitly.

Signed-off-by: Muhammad Falak R Wani <[email protected]>
---
drivers/crypto/qat/qat_common/adf_ctl_drv.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/crypto/qat/qat_common/adf_ctl_drv.c b/drivers/crypto/qat/qat_common/adf_ctl_drv.c
index db21b49..0f0677f 100644
--- a/drivers/crypto/qat/qat_common/adf_ctl_drv.c
+++ b/drivers/crypto/qat/qat_common/adf_ctl_drv.c
@@ -273,7 +273,6 @@ static int adf_ctl_is_device_in_use(int id)
static int adf_ctl_stop_devices(uint32_t id)
{
struct adf_accel_dev *accel_dev;
- int ret = 0;

list_for_each_entry(accel_dev, adf_devmgr_get_head(), list) {
if (id == accel_dev->accel_id || id == ADF_CFG_ALL_DEVICES) {
@@ -298,7 +297,7 @@ static int adf_ctl_stop_devices(uint32_t id)
adf_dev_shutdown(accel_dev);
}
}
- return ret;
+ return 0;
}

static int adf_ctl_ioctl_dev_stop(struct file *fp, unsigned int cmd,
--
1.9.1

2016-05-11 20:22:41

by Tadeusz Struk

Subject: Re: [PATCH] crypto: qat: remove unused vairable.

On 05/11/2016 12:28 PM, Muhammad Falak R Wani wrote:
> Remove the unused variable ret, and return 0 explicitly.

Thanks for the patch. In this case it will be even better
to change the adf_ctl_stop_devices() to a void function.
---8<---
Subject: [PATCH] crypto: qat - change the adf_ctl_stop_devices to void

Change the adf_ctl_stop_devices to a void function.

Signed-off-by: Tadeusz Struk <[email protected]>
---
drivers/crypto/qat/qat_common/adf_ctl_drv.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/crypto/qat/qat_common/adf_ctl_drv.c b/drivers/crypto/qat/qat_common/adf_ctl_drv.c
index db21b49..abc7a7f 100644
--- a/drivers/crypto/qat/qat_common/adf_ctl_drv.c
+++ b/drivers/crypto/qat/qat_common/adf_ctl_drv.c
@@ -270,10 +270,9 @@ static int adf_ctl_is_device_in_use(int id)
return 0;
}

-static int adf_ctl_stop_devices(uint32_t id)
+static void adf_ctl_stop_devices(uint32_t id)
{
struct adf_accel_dev *accel_dev;
- int ret = 0;

list_for_each_entry(accel_dev, adf_devmgr_get_head(), list) {
if (id == accel_dev->accel_id || id == ADF_CFG_ALL_DEVICES) {
@@ -298,7 +297,6 @@ static int adf_ctl_stop_devices(uint32_t id)
adf_dev_shutdown(accel_dev);
}
}
- return ret;
}

static int adf_ctl_ioctl_dev_stop(struct file *fp, unsigned int cmd,
@@ -327,9 +325,8 @@ static int adf_ctl_ioctl_dev_stop(struct file *fp, unsigned int cmd,
pr_info("QAT: Stopping acceleration device qat_dev%d.\n",
ctl_data->device_id);

- ret = adf_ctl_stop_devices(ctl_data->device_id);
- if (ret)
- pr_err("QAT: failed to stop device.\n");
+ adf_ctl_stop_devices(ctl_data->device_id);
+
out:
kfree(ctl_data);
return ret;

Thanks,
--
TS

2016-05-13 09:33:32

by Herbert Xu

Subject: Re: [PATCH] crypto: qat: remove unused vairable.

On Wed, May 11, 2016 at 01:21:29PM -0700, Tadeusz Struk wrote:
> On 05/11/2016 12:28 PM, Muhammad Falak R Wani wrote:
> > Remove the unused variable ret, and return 0 explicitly.
>
> Thanks for the patch. In this case it will be even better
> to change the adf_ctl_stop_devices() to a void function.
> ---8<---
> Subject: [PATCH] crypto: qat - change the adf_ctl_stop_devices to void
>
> Change the adf_ctl_stop_devices to a void function.
>
> Signed-off-by: Tadeusz Struk <[email protected]>

Patch applied. Thanks!
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt