2016-08-29 17:10:16

by Arvind Yadav

[permalink] [raw]

Subject: [PATCH] char: hw_random: bcm2835: handle of_iomap failures in bcm2835 driver

---

Check return value of of_iomap and handle errors correctly.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/char/hw_random/bcm2835-rng.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/char/hw_random/bcm2835-rng.c b/drivers/char/hw_random/bcm2835-rng.c
index af21492..574211a 100644
--- a/drivers/char/hw_random/bcm2835-rng.c
+++ b/drivers/char/hw_random/bcm2835-rng.c
@@ -92,9 +92,10 @@ static int bcm2835_rng_probe(struct platform_device *pdev)
bcm2835_rng_ops.priv = (unsigned long)rng_base;

rng_id = of_match_node(bcm2835_rng_of_match, np);
- if (!rng_id)
+ if (!rng_id) {
+ iounmap(rng_base);
return -EINVAL;
-
+ }
/* Check for rng init function, execute it */
rng_setup = rng_id->data;
if (rng_setup)
--
2.7.4

2016-08-30 18:26:08

by Eric Anholt

[permalink] [raw]

Subject: Re: [PATCH] char: hw_random: bcm2835: handle of_iomap failures in bcm2835 driver

---

Arvind Yadav <[email protected]> writes:

> Check return value of of_iomap and handle errors correctly.
>
> Signed-off-by: Arvind Yadav <[email protected]>

Acked-by: Eric Anholt <[email protected]>

---

Attachments:

signature.asc (800.00 B)

2016-09-07 13:20:01

by Herbert Xu

[permalink] [raw]

Subject: Re: [PATCH] char: hw_random: bcm2835: handle of_iomap failures in bcm2835 driver

---

On Mon, Aug 29, 2016 at 10:40:16PM +0530, Arvind Yadav wrote:
> Check return value of of_iomap and handle errors correctly.
>
> Signed-off-by: Arvind Yadav <[email protected]>

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt