2016-10-17 10:16:08

by Tobias Klauser

Subject: [PATCH] padata: Remove unused but set variables

Remove the unused but set variable pinst in padata_parallel_worker to
fix the following warning when building with 'W=1':

kernel/padata.c: In function ‘padata_parallel_worker’:
kernel/padata.c:68:26: warning: variable ‘pinst’ set but not used [-Wunused-but-set-variable]

Also remove the now unused variable pd which is only used to set pinst.

Signed-off-by: Tobias Klauser <[email protected]>
---
kernel/padata.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/kernel/padata.c b/kernel/padata.c
index 7848f0566403..05316c9f32da 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -64,15 +64,11 @@ static int padata_cpu_hash(struct parallel_data *pd)
static void padata_parallel_worker(struct work_struct *parallel_work)
{
struct padata_parallel_queue *pqueue;
- struct parallel_data *pd;
- struct padata_instance *pinst;
LIST_HEAD(local_list);

local_bh_disable();
pqueue = container_of(parallel_work,
struct padata_parallel_queue, work);
- pd = pqueue->pd;
- pinst = pd->pinst;

spin_lock(&pqueue->parallel.lock);
list_replace_init(&pqueue->parallel.list, &local_list);
--
2.9.0

2016-10-21 09:00:57

by Steffen Klassert

Subject: Re: [PATCH] padata: Remove unused but set variables

On Mon, Oct 17, 2016 at 12:16:08PM +0200, Tobias Klauser wrote:
> Remove the unused but set variable pinst in padata_parallel_worker to
> fix the following warning when building with 'W=1':
>
> kernel/padata.c: In function ‘padata_parallel_worker’:
> kernel/padata.c:68:26: warning: variable ‘pinst’ set but not used [-Wunused-but-set-variable]
>
> Also remove the now unused variable pd which is only used to set pinst.
>
> Signed-off-by: Tobias Klauser <[email protected]>

Acked-by: Steffen Klassert <[email protected]>

Thanks!

2016-10-25 03:38:43

by Herbert Xu

Subject: Re: [PATCH] padata: Remove unused but set variables

Steffen Klassert <[email protected]> wrote:
> On Mon, Oct 17, 2016 at 12:16:08PM +0200, Tobias Klauser wrote:
>> Remove the unused but set variable pinst in padata_parallel_worker to
>> fix the following warning when building with 'W=1':
>>
>> kernel/padata.c: In function ‘padata_parallel_worker’:
>> kernel/padata.c:68:26: warning: variable ‘pinst’ set but not used [-Wunused-but-set-variable]
>>
>> Also remove the now unused variable pd which is only used to set pinst.
>>
>> Signed-off-by: Tobias Klauser <[email protected]>
>
> Acked-by: Steffen Klassert <[email protected]>

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt