2017-04-11 16:04:16

by Wei Yongjun

Subject: [PATCH -next] crypto: caam - fix error return code in caam_qi_init()

From: Wei Yongjun <[email protected]>

Fix to return error code -ENOMEM from the kmem_cache_create() error
handling case instead of 0(err is 0 here), as done elsewhere in this
function.

Fixes: 67c2315def06 ("crypto: caam - add Queue Interface (QI) backend support")
Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/crypto/caam/qi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/caam/qi.c b/drivers/crypto/caam/qi.c
index 45de8fd..1990ed4 100644
--- a/drivers/crypto/caam/qi.c
+++ b/drivers/crypto/caam/qi.c
@@ -789,7 +789,7 @@ int caam_qi_init(struct platform_device *caam_pdev)
dev_err(qidev, "Can't allocate CAAM cache\n");
free_rsp_fqs();
platform_device_unregister(qi_pdev);
- return err;
+ return -ENOMEM;
}

/* Done with the CGRs; restore the cpus allowed mask */

2017-04-12 08:18:10

by Horia Geanta

Subject: Re: [PATCH -next] crypto: caam - fix error return code in caam_qi_init()

On 4/11/2017 7:04 PM, Wei Yongjun wrote:
> From: Wei Yongjun <[email protected]>
>
> Fix to return error code -ENOMEM from the kmem_cache_create() error
> handling case instead of 0(err is 0 here), as done elsewhere in this
> function.
>
> Fixes: 67c2315def06 ("crypto: caam - add Queue Interface (QI) backend support")
> Signed-off-by: Wei Yongjun <[email protected]>
Acked-by: Horia Geant? <[email protected]>

Thanks,
Horia

2017-04-21 13:15:28

by Herbert Xu

Subject: Re: [PATCH -next] crypto: caam - fix error return code in caam_qi_init()

On Tue, Apr 11, 2017 at 04:04:09PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <[email protected]>
>
> Fix to return error code -ENOMEM from the kmem_cache_create() error
> handling case instead of 0(err is 0 here), as done elsewhere in this
> function.
>
> Fixes: 67c2315def06 ("crypto: caam - add Queue Interface (QI) backend support")
> Signed-off-by: Wei Yongjun <[email protected]>

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt