2017-09-19 03:19:03

by Herbert Xu

Subject: vmx ghash buggy on ppc64le

Hi:

I have received a report that ghash on ppc64le does not interoperate
with other implementations of ghash, e.g., on x86-64.

https://bugzilla.redhat.com/show_bug.cgi?id=1490972

Could you guys take a look at this and see if this is a bug in
the mainline vmx driver too?

Thanks!
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2017-10-16 23:10:18

by Paulo Flabiano Smorigo

Subject: Re: vmx ghash buggy on ppc64le

Tue, Sep 19, 2017 at 11:18:45AM +0800, Herbert Xu wrote:
> Hi:
>
> I have received a report that ghash on ppc64le does not interoperate
> with other implementations of ghash, e.g., on x86-64.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1490972
>
> Could you guys take a look at this and see if this is a bug in
> the mainline vmx driver too?
>
> Thanks!
> --
> Email: Herbert Xu <[email protected]>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
>

Hi Herbert,

It seems that this bug is affected by the fact that ctr mode is using
blkcipher for the fallback.

I just sent a patch [1] to make it use skcipher and, since then, ipsec
with ikev2 and ghash are working fine for ppc64 and ppc64le.

Best regards,

--
Paulo Flabiano Smorigo
IBM Linux Technology Center

[1] https://lkml.org/lkml/2017/10/16/911

2017-10-17 13:10:40

by Herbert Xu

Subject: Re: vmx ghash buggy on ppc64le

On Mon, Oct 16, 2017 at 09:09:53PM -0200, Paulo Flabiano Smorigo wrote:
> Tue, Sep 19, 2017 at 11:18:45AM +0800, Herbert Xu wrote:
> > Hi:
> >
> > I have received a report that ghash on ppc64le does not interoperate
> > with other implementations of ghash, e.g., on x86-64.
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=1490972
> >
> > Could you guys take a look at this and see if this is a bug in
> > the mainline vmx driver too?
> >
> > Thanks!
> > --
> > Email: Herbert Xu <[email protected]>
> > Home Page: http://gondor.apana.org.au/~herbert/
> > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
> >
>
> Hi Herbert,
>
> It seems that this bug is affected by the fact that ctr mode is using
> blkcipher for the fallback.
>
> I just sent a patch [1] to make it use skcipher and, since then, ipsec
> with ikev2 and ghash are working fine for ppc64 and ppc64le.

Thanks!
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt