2019-03-01 14:03:26

by Kamil Konieczny

Subject: [PATCH] crypto: s5p-sss - fix AES support for Exynos5433

Commit 0918f18c7179 ("crypto: s5p - add AES support for Exynos5433")
introduced bug in dereferencing clk_names[1] on platforms different from
Exynos5433. On Exynos board XU3 call trace is:

"Unable to handle kernel paging request at virtual address 00004000"
(strcmp) from [<c0774014>] (of_property_match_string+0x58/0xd0)
...
(devm_clk_get) from [<c075c248>] (s5p_aes_probe+0xd4/0x4a0)
(s5p_aes_probe) from [<c059dbc4>] (platform_drv_probe+0x6c/0xa4)

Fix this by setting array clk_names size to 2.

Fixes: 0918f18c7179 ("crypto: s5p - add AES support for Exynos5433")
Reported-by: Krzysztof Kozlowski <[email protected]>
Signed-off-by: Kamil Konieczny <[email protected]>
---
drivers/crypto/s5p-sss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
index 3f45cc5cb94a..2fb4ae459c45 100644
--- a/drivers/crypto/s5p-sss.c
+++ b/drivers/crypto/s5p-sss.c
@@ -241,7 +241,7 @@
struct samsung_aes_variant {
unsigned int aes_offset;
unsigned int hash_offset;
- const char *clk_names[];
+ const char *clk_names[2];
};

struct s5p_aes_reqctx {
--
2.21.0

2019-03-01 14:19:26

by Krzysztof Kozlowski

Subject: Re: [PATCH] crypto: s5p-sss - fix AES support for Exynos5433

On Fri, 1 Mar 2019 at 15:03, Kamil Konieczny
<[email protected]> wrote:
>
> Commit 0918f18c7179 ("crypto: s5p - add AES support for Exynos5433")
> introduced bug in dereferencing clk_names[1] on platforms different from
> Exynos5433. On Exynos board XU3 call trace is:
>
> "Unable to handle kernel paging request at virtual address 00004000"
> (strcmp) from [<c0774014>] (of_property_match_string+0x58/0xd0)
> ...
> (devm_clk_get) from [<c075c248>] (s5p_aes_probe+0xd4/0x4a0)
> (s5p_aes_probe) from [<c059dbc4>] (platform_drv_probe+0x6c/0xa4)
>
> Fix this by setting array clk_names size to 2.
>
> Fixes: 0918f18c7179 ("crypto: s5p - add AES support for Exynos5433")
> Reported-by: Krzysztof Kozlowski <[email protected]>
> Signed-off-by: Kamil Konieczny <[email protected]>
> ---
> drivers/crypto/s5p-sss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for fast fix!

Reviewed-by: Krzysztof Kozlowski <[email protected]>
Tested on Exynos5422 Odroid HC1:
Tested-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2019-03-07 08:26:04

by Herbert Xu

Subject: Re: [PATCH] crypto: s5p-sss - fix AES support for Exynos5433

On Fri, Mar 01, 2019 at 03:02:54PM +0100, Kamil Konieczny wrote:
> Commit 0918f18c7179 ("crypto: s5p - add AES support for Exynos5433")
> introduced bug in dereferencing clk_names[1] on platforms different from
> Exynos5433. On Exynos board XU3 call trace is:
>
> "Unable to handle kernel paging request at virtual address 00004000"
> (strcmp) from [<c0774014>] (of_property_match_string+0x58/0xd0)
> ...
> (devm_clk_get) from [<c075c248>] (s5p_aes_probe+0xd4/0x4a0)
> (s5p_aes_probe) from [<c059dbc4>] (platform_drv_probe+0x6c/0xa4)
>
> Fix this by setting array clk_names size to 2.
>
> Fixes: 0918f18c7179 ("crypto: s5p - add AES support for Exynos5433")
> Reported-by: Krzysztof Kozlowski <[email protected]>
> Signed-off-by: Kamil Konieczny <[email protected]>
> ---
> drivers/crypto/s5p-sss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt