2019-04-26 01:49:30

by kernel test robot

[permalink] [raw]
Subject: [cryptodev:master 130/163] drivers/crypto/ccree/cc_driver.c:38:6: sparse: sparse: symbol 'cc_sec_disable' was not declared. Should it be static?

tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
head: 1036633e10f86b793e60dd8698c65df6712cad2a
commit: f98f6e2134bd3ee5db0594dc399f9562ecc2d08a [130/163] crypto: ccree - add support for sec disabled mode
reproduce:
# apt-get install sparse
git checkout f98f6e2134bd3ee5db0594dc399f9562ecc2d08a
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <[email protected]>


sparse warnings: (new ones prefixed by >>)

>> drivers/crypto/ccree/cc_driver.c:38:6: sparse: sparse: symbol 'cc_sec_disable' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation


2019-04-26 01:50:09

by kernel test robot

[permalink] [raw]
Subject: [RFC PATCH cryptodev] crypto: cc_sec_disable can be static


Fixes: f98f6e2134bd ("crypto: ccree - add support for sec disabled mode")
Signed-off-by: kbuild test robot <[email protected]>
---
cc_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/ccree/cc_driver.c b/drivers/crypto/ccree/cc_driver.c
index 255d236..13b54a2 100644
--- a/drivers/crypto/ccree/cc_driver.c
+++ b/drivers/crypto/ccree/cc_driver.c
@@ -35,7 +35,7 @@ bool cc_dump_bytes;
module_param_named(dump_bytes, cc_dump_bytes, bool, 0600);
MODULE_PARM_DESC(cc_dump_bytes, "Dump buffers to kernel log as debugging aid");

-bool cc_sec_disable;
+static bool cc_sec_disable;
module_param_named(sec_disable, cc_sec_disable, bool, 0600);
MODULE_PARM_DESC(cc_sec_disable, "Disable security functions");


2019-04-28 07:12:48

by Gilad Ben-Yossef

[permalink] [raw]
Subject: Re: [RFC PATCH cryptodev] crypto: cc_sec_disable can be static

On Fri, Apr 26, 2019 at 4:03 AM kbuild test robot <[email protected]> wrote:
>
>
> Fixes: f98f6e2134bd ("crypto: ccree - add support for sec disabled mode")
> Signed-off-by: kbuild test robot <[email protected]>

Acked-By: Gilad Ben-Yossef <[email protected]>

Thanks!
Gilad

--
Gilad Ben-Yossef
Chief Coffee Drinker

values of β will give rise to dom!