2019-07-24 07:57:27

by Nishka Dasgupta

Subject: [PATCH v2] crypto: nx: nx-842-powernv: Add of_node_put() before return

Each iteration of for_each_compatible_node puts the previous node, but
in the case of a return from the middle of the loop, there is no put,
thus causing a memory leak. Add an of_node_put before the return.
Issue found with Coccinelle.

Acked-by: Stewart Smith <[email protected]>
Signed-off-by: Nishka Dasgupta <[email protected]>

---
Changes in v2:
- Fixed commit message to match the loop in question.

drivers/crypto/nx/nx-842-powernv.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/nx/nx-842-powernv.c b/drivers/crypto/nx/nx-842-powernv.c
index e78ff5c65ed6..c037a2403b82 100644
--- a/drivers/crypto/nx/nx-842-powernv.c
+++ b/drivers/crypto/nx/nx-842-powernv.c
@@ -1020,6 +1020,7 @@ static __init int nx842_powernv_init(void)
ret = nx842_powernv_probe_vas(dn);
if (ret) {
nx842_delete_coprocs();
+ of_node_put(dn);
return ret;
}
}
--
2.19.1

2019-08-02 08:57:41

by Herbert Xu

Subject: Re: [PATCH v2] crypto: nx: nx-842-powernv: Add of_node_put() before return

On Wed, Jul 24, 2019 at 01:24:33PM +0530, Nishka Dasgupta wrote:
> Each iteration of for_each_compatible_node puts the previous node, but
> in the case of a return from the middle of the loop, there is no put,
> thus causing a memory leak. Add an of_node_put before the return.
> Issue found with Coccinelle.
>
> Acked-by: Stewart Smith <[email protected]>
> Signed-off-by: Nishka Dasgupta <[email protected]>
>
> ---
> Changes in v2:
> - Fixed commit message to match the loop in question.
>
> drivers/crypto/nx/nx-842-powernv.c | 1 +
> 1 file changed, 1 insertion(+)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt