2019-07-29 13:56:01

by Gary R Hook

Subject: [PATCH v2] crypto: ccp - Log an error message when ccp-crypto fails to load

From: Gary R Hook <[email protected]>

If there are no CCP devices on the system, ccp-crypto will not load.
Write a message to the system log clarifying the reason for the failure
of the modprobe operation

Signed-off-by: Gary R Hook <[email protected]>
---

Changes since v1:
- Add missing signed-off-by

drivers/crypto/ccp/ccp-crypto-main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/ccp/ccp-crypto-main.c b/drivers/crypto/ccp/ccp-crypto-main.c
index 818096490829..8ee4cb45a3f3 100644
--- a/drivers/crypto/ccp/ccp-crypto-main.c
+++ b/drivers/crypto/ccp/ccp-crypto-main.c
@@ -405,8 +405,10 @@ static int ccp_crypto_init(void)
int ret;

ret = ccp_present();
- if (ret)
+ if (ret) {
+ pr_err("Cannot load: there are no available CCPs\n");
return ret;
+ }

spin_lock_init(&req_queue_lock);
INIT_LIST_HEAD(&req_queue.cmds);
--
2.17.1

2019-08-09 06:11:20

by Herbert Xu

Subject: Re: [PATCH v2] crypto: ccp - Log an error message when ccp-crypto fails to load

On Mon, Jul 29, 2019 at 12:56:08PM +0000, Hook, Gary wrote:
> From: Gary R Hook <[email protected]>
>
> If there are no CCP devices on the system, ccp-crypto will not load.
> Write a message to the system log clarifying the reason for the failure
> of the modprobe operation
>
> Signed-off-by: Gary R Hook <[email protected]>
> ---
>
> Changes since v1:
> - Add missing signed-off-by
>
> drivers/crypto/ccp/ccp-crypto-main.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt